From: David Howells <dhowells@redhat.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: dhowells@redhat.com, Christoph Hellwig <hch@infradead.org>,
Eric Biggers <ebiggers3@gmail.com>,
linux-fsdevel@vger.kernel.org, mtk.manpages@gmail.com,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Linux API <linux-api@vger.kernel.org>,
linux-xfs@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] statx: reject unknown flags when using NULL path
Date: Fri, 31 Mar 2017 16:51:24 +0100 [thread overview]
Message-ID: <21301.1490975484@warthog.procyon.org.uk> (raw)
In-Reply-To: <20170331154315.GB29622@ZenIV.linux.org.uk>
Al Viro <viro@ZenIV.linux.org.uk> wrote:
> > can we get this in please? It would be sad to grow another syscall
> > with an unchecked flags argument..
>
> Applied, will be in tonight pull request...
I'm not convinced that this is right. I'm more inclined to let any flag be
passed that is available to statx() with a filename and just mask off the
bits before handing them on.
David
next prev parent reply other threads:[~2017-03-31 15:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-11 6:58 [PATCH] statx: reject unknown flags when using NULL path Eric Biggers
2017-03-20 17:11 ` Eric Biggers
2017-03-20 17:44 ` Christoph Hellwig
2017-03-31 15:39 ` Christoph Hellwig
2017-03-31 15:43 ` Al Viro
2017-03-31 15:51 ` David Howells [this message]
2017-03-31 16:02 ` Christoph Hellwig
2017-03-31 16:58 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21301.1490975484@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=ebiggers3@gmail.com \
--cc=ebiggers@google.com \
--cc=hch@infradead.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).