From mboxrd@z Thu Jan  1 00:00:00 1970
From: Valdis.Kletnieks@vt.edu
Subject: Re: [PATCH 6/7] vfs: only add " (deleted)" where necessary
Date: Mon, 02 Aug 2010 09:00:56 -0400
Message-ID: <215565.1280754056@localhost>
References: <20100802111955.025275647@szeredi.hu>
            <20100802112024.851698363@szeredi.hu>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1280754056_76572P";
	 micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
To: Miklos Szeredi <miklos@szeredi.hu>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: Your message of "Mon, 02 Aug 2010 13:20:01 +0200."
             <20100802112024.851698363@szeredi.hu>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

--==_Exmh_1280754056_76572P
Content-Type: text/plain; charset=us-ascii

On Mon, 02 Aug 2010 13:20:01 +0200, Miklos Szeredi said:

> Index: linux-2.6/fs/dcache.c
> ===================================================================
> --- linux-2.6.orig/fs/dcache.c	2010-07-06 18:08:16.000000000 +0200
> +++ linux-2.6/fs/dcache.c	2010-07-06 18:08:19.000000000 +0200
> @@ -1977,8 +1977,7 @@ global_root:
>   * @buffer: buffer to return value in
>   * @buflen: buffer length
>   *
> - * Convert a dentry into an ASCII path name. If the entry has been deleted
> - * the string " (deleted)" is appended. Note that this is ambiguous.
> + * Convert a dentry into an ASCII path name.
>   *
>   * Returns a pointer into the buffer or an error code if the
>   * path was too long.

I'd prefer the comment about it being ambiguous remain.  I'm waiting to see how
long it takes for somebody to create a security hole by creating a file called
'/etc/some/thing/important (deleted)' and having some software Do The Wrong
Thing instead to /etc/some/thing/important.


--==_Exmh_1280754056_76572P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Exmh version 2.5 07/13/2001

iD8DBQFMVsGIcC3lWbTT17ARAhsYAJ0S6HqXhAC4jZvP3AW9G1dyrt2zZwCg6Ilz
Ex+d+Ab1kZ3eH1j6TLZF94g=
=96rk
-----END PGP SIGNATURE-----

--==_Exmh_1280754056_76572P--