linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Jan Kara <jack@suse.cz>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [git pull] vfs.git sysv pile
Date: Fri, 03 Mar 2023 06:10:40 +0100	[thread overview]
Message-ID: <2187011.72vocr9iq0@suse> (raw)
In-Reply-To: <ZAEkveTgVqKau+ab@ZenIV>

On giovedì 2 marzo 2023 23:35:41 CET Al Viro wrote:
> On Thu, Mar 02, 2023 at 07:35:59PM +0000, Al Viro wrote:
> > On Thu, Mar 02, 2023 at 12:31:46PM +0100, Fabio M. De Francesco wrote:
> > > But... when yesterday Al showed his demo patchset I probably interpreted
> > > his
> > > reply the wrong way and thought that since he spent time for the demo he
> > > wanted to put this to completion on his own.
> > > 
> > > Now I see that you are interpreting his message as an invite to use them
> > > to
> > > shorten the time...
> > > 
> > > Furthermore I'm not sure about how I should credit him. Should I merely
> > > add a
> > > "Suggested-by:" tag or more consistent "Co-authored-by: Al Viro <...>"?
> > > Since
> > > he did so much I'd rather the second but I need his permission.
> > 
> > What, for sysv part?  It's already in mainline; for minixfs and ufs, if 
you
> > want to do those - whatever you want, I'd probably go for "modeled after
> > sysv series in 6.2" - "Suggested-by" in those would suffice...
> > 
> > > @Al,
> > > 
> > > Can I really proceed with *your* work? What should the better suited tag
> > > be to credit you for the patches?
> > > 
> > > If you can reply today or at least by Friday, I'll pick your demo
> > > patchset,
> > > put it to completion, make the patches and test them with (x)fstests on 
a
> > > QEMU/KVM x86_32 bit VM, with 6GB RAM, running an HIGHMEM64GB enabled
> > > kernel.
> > 
> > Frankly, ext2 patchset had been more along the lines of "here's what
> > untangling the calling conventions in ext2 would probably look like" than
> > anything else. If you are willing to test (and review) that sucker and it
> > turns out to be OK, I'll be happy to slap your tested-by on those during
> > rebase and feed them to Jan...
> 
> PS: now we can actually turn
>         kunmap_local((void *)((unsigned long)page_addr & PAGE_MASK));
> into
> 	kunmap_local(page_addr);
> 
> provided that commit doing that includes something along the lines of
> 
> Do-Not-Backport-Without: 88d7b12068b9 "highmem: round down the address 
passed
> to kunmap_flush_on_unmap()"
> 
> in commit message.

I'll do it for fs/sysv.

Instead there is no need to change anything in my series for fs/ufs (it was  
made as if we already had 88d7b12068b9 "highmem: round down the address passed 
to kunmap_flush_on_unmap()" in place).

Thanks,

Fabio




  reply	other threads:[~2023-03-03  5:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-24  3:26 [git pull] vfs.git sysv pile Al Viro
2023-02-25  3:40 ` pr-tracker-bot
2023-03-01 11:20 ` Fabio M. De Francesco
2023-03-01 13:00   ` Jan Kara
2023-03-01 13:21     ` Fabio M. De Francesco
2023-03-01 14:14     ` Al Viro
2023-03-02  9:59       ` Jan Kara
2023-03-02 11:31         ` Fabio M. De Francesco
2023-03-02 19:35           ` Al Viro
2023-03-02 22:35             ` Al Viro
2023-03-03  5:10               ` Fabio M. De Francesco [this message]
2023-03-03  4:58             ` Fabio M. De Francesco
2023-03-08 17:40             ` Fabio M. De Francesco
2023-03-09 13:45               ` Fabio M. De Francesco
2023-03-02 19:26         ` Al Viro
2023-03-03  9:24           ` Jan Kara
2023-03-15 18:08       ` Fabio M. De Francesco
2023-03-16  9:00         ` Jan Kara
2023-03-16 10:30           ` Fabio M. De Francesco
2023-03-20 11:18             ` Fabio M. De Francesco
2023-03-20 12:47               ` Jan Kara
2023-03-27 10:29                 ` Fabio M. De Francesco
2023-05-25 20:10                   ` Jan Kara
2023-05-26 10:32                     ` Fabio M. De Francesco
2023-05-26 13:25                       ` Fabio M. De Francesco
2023-05-29  9:02                         ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2187011.72vocr9iq0@suse \
    --to=fmdefrancesco@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).