From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fhigh5-smtp.messagingengine.com (fhigh5-smtp.messagingengine.com [103.168.172.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F39E23746 for ; Thu, 4 Jul 2024 17:20:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.156 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720113621; cv=none; b=eOqM8O9HsRbEJT+2SAWSPSBg83/gDEsxUPGhxRAUDcTdCtaFwHtqQJ+UaxDD4GwZz/mulU8qbtKwcyVlTiMO+/0BNtYboAY06zgWffvUxv1p8e63eoc9SoKcfL8ujy1ZAII1keA0qNJRQLEWtapmKbxEYyewyiL15Nxdi/ENo5s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720113621; c=relaxed/simple; bh=QgHC9lZzkLcGjLblk8kG4iJfDzNiSi0MHAG/42IQ7L8=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=LrbgNxPC/DxuFhJyuQDb40gk8v1zHkqrHfXcoVrC57b4nEUvDlQttRxv9QwSUwEgzmdJeJGKyBnfI1rRAIzLI/N507Gek7OLZyg1BX4qB50qRwL8UR5QUKlT+6gpTqavUwAGdixlT11kPhIgNN6gWhEoel9qoKDvVhBtcinpprE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.fm; spf=pass smtp.mailfrom=fastmail.fm; dkim=pass (2048-bit key) header.d=fastmail.fm header.i=@fastmail.fm header.b=re7+uJgv; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=tHdFMi0t; arc=none smtp.client-ip=103.168.172.156 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.fm Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.fm Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fastmail.fm header.i=@fastmail.fm header.b="re7+uJgv"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="tHdFMi0t" Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 6DFB51140222; Thu, 4 Jul 2024 13:20:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 04 Jul 2024 13:20:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1720113618; x=1720200018; bh=ucCFHC203Wvbo7KdD/a7pVPwOUsZ8fD+RI2OkLTolNQ=; b= re7+uJgvqLm8umlVm0f30JlV2bispZ1Wa7f4Ti9A/FUhGrV335mh/5MvZMtl7l5D 94DAPGcGB+G8T819fAJPtkXViCOyg/QyhEiTD9gDoISDwA5/2R4YKYzjbYJBcF5A fsohelfYsDk4KREA92JmnrfmJoIVaiyalnCEoUh1ydjO0lfaBx+Cvwyox2qRjLbp w93arIRX/CIwul9hNCz5WZj842TrfzuJf/jI7gHnqWtOseM65Z8Aj3e+fHYUl+B9 Zm+yTYDFqi+gFWdYCJe2t3o+RVv7zWZxqEK6y5mwAwiJRQWS8hBMXFehj4aGvPn4 71LVEVuXmxyK0y5qAz8ADQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1720113618; x= 1720200018; bh=ucCFHC203Wvbo7KdD/a7pVPwOUsZ8fD+RI2OkLTolNQ=; b=t HdFMi0tQvuRLHvmSDhBgvasdUT2N2K1X/lx8RNWn+R1DoWoMuUdh5h13eu3nYUxB dz9BvsDymztyPTMtpZEeUC2bkI7VqmkGLEs4StxEY7iu6zm8JBIU3s70+xrt0kg+ gPDl6354jhUU1OzqI1ArvNHWXlPyVF88IHnly6/zSzCsogVBvtGug6gmBdOjfQTk nHG3XAxn2kq2fqY+ZzSoAH33zwnhseCiGgvTUugq4BUhf23AXdhZM7yAGS6C0PJd 7zLxlYTIByaS5zM9ZmeVnRQ7dzTYBBgctJJQuHy//97nB21qB+5cLtTi8kTdNE23 cVFBQwsw6i5DkYBuiqfVg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudelgdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttddvjeenucfhrhhomhepuegvrhhn ugcuufgthhhusggvrhhtuceosggvrhhnugdrshgthhhusggvrhhtsehfrghsthhmrghilh drfhhmqeenucggtffrrghtthgvrhhnpeekffevgfdttddukeeiffelheelfeehhfduleei udehhfejhfeghedvfeekteefteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegsvghrnhgurdhstghhuhgsvghrthesfhgrshhtmhgrihhlrdhf mh X-ME-Proxy: Feedback-ID: id8a24192:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 4 Jul 2024 13:20:17 -0400 (EDT) Message-ID: <21a2cfee-0067-43d1-b605-68a99abd9f53@fastmail.fm> Date: Thu, 4 Jul 2024 19:20:16 +0200 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH][RESEND] fuse: add simple request tracepoints To: Josef Bacik , miklos@szeredi.hu, linux-fsdevel@vger.kernel.org References: From: Bernd Schubert Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/3/24 16:38, Josef Bacik wrote: > I've been timing various fuse operations and it's quite annoying to do > with kprobes. Add two tracepoints for sending and ending fuse requests > to make it easier to debug and time various operations. Thanks, this is super helpful. [...] > > + EM( FUSE_STATX, "FUSE_STATX") \ > + EMe(CUSE_INIT, "CUSE_INIT") > + > +/* > + * This will turn the above table into TRACE_DEFINE_ENUM() for each of the > + * entries. > + */ > +#undef EM > +#undef EMe > +#define EM(a, b) TRACE_DEFINE_ENUM(a); > +#define EMe(a, b) TRACE_DEFINE_ENUM(a); I'm not super familiar with tracepoints and I'm a bit list why "EMe" is needed in addition to EM? CUSE_INIT is just another number? Thanks, Bernd