From: David Howells <dhowells@redhat.com>
To: "Yan, Zheng" <ukernel@gmail.com>
Cc: dhowells@redhat.com, ceph-devel <ceph-devel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] ceph: Convert to fs_context
Date: Wed, 27 Mar 2019 10:10:32 +0000 [thread overview]
Message-ID: <2235.1553681432@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAAM7YAnsYr0uQixmcv-=UDLWdmdJmbEN2D_zBcFQq2j-s+xtiw@mail.gmail.com>
Yan, Zheng <ukernel@gmail.com> wrote:
> > - if (fsopt->sb_flags != other->mount_options->sb_flags) {
> > + if (fc->sb_flags != sb->s_flags) {
Fixed with:
@@ -945,7 +945,7 @@ static int ceph_compare_super(struct super_block *sb, struct fs_context *fc)
dout("fsid doesn't match\n");
return 0;
}
- if (fc->sb_flags != sb->s_flags) {
+ if (fc->sb_flags != (sb->s_flags & ~SB_BORN)) {
dout("flags differ\n");
return 0;
}
David
prev parent reply other threads:[~2019-03-27 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 14:49 [RFC PATCH] ceph: Convert to fs_context David Howells
2019-03-20 14:50 ` David Howells
2019-03-25 9:18 ` Yan, Zheng
2019-03-27 8:59 ` Yan, Zheng
2019-03-27 10:10 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2235.1553681432@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ukernel@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox