From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
Cc: Mori.Takahiro@ab.MitsubishiElectric.co.jp,
motai.hirotaka@aj.mitsubishielectric.co.jp,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-fsdevel@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] staging: exfat: remove symlink feature.
Date: Sun, 23 Feb 2020 03:04:40 -0500 [thread overview]
Message-ID: <225183.1582445080@turing-police> (raw)
In-Reply-To: <20200219055727.12867-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
On Wed, 19 Feb 2020 14:57:27 +0900, Tetsuhiro Kohada said:
> Remove symlink feature completely.
>
> Becouse
> -Uses reserved areas(defined in the Microsoft exfat specification), causing future incompatibilities.
> -Not described in Microsoft exfat specifications or SD standards.
> -For REMOVABLE media, causes incompatibility with other implementations.
> -Not supported by other major exfat drivers.
> -Not implemented symlink feature in linux FAT/VFAT.
>
> Remove this feature completely because of serious media compatibility issues.
> (Can't enable even with CONFIG)
>
> If you have any questions about this patch, please let me know.
>
> Reviewed-by: Takahiro Mori <Mori.Takahiro@ab.MitsubishiElectric.co.jp>
> Signed-off-by: Tetsuhiro Kohada <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
Symlink support would be nice, but Tetsuhiro is right - this driver's
implementation isn't the way to do it. Heaving it over the side and getting a
standard fat/vfat/exfat extension done is the right way.
Acked-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
prev parent reply other threads:[~2020-02-23 8:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 5:57 [RFC PATCH] staging: exfat: remove symlink feature Tetsuhiro Kohada
2020-02-23 8:04 ` Valdis Klētnieks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=225183.1582445080@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp \
--cc=Mori.Takahiro@ab.MitsubishiElectric.co.jp \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=motai.hirotaka@aj.mitsubishielectric.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).