From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [rfc][patch 3/5] afs: new aops Date: Wed, 14 Nov 2007 15:57:46 +0000 Message-ID: <22543.1195055866@redhat.com> References: <20071114151825.GA20973@wotan.suse.de> <20071114042420.GF557@wotan.suse.de> <20071113004459.GE30650@wotan.suse.de> <20071113001548.GA30650@wotan.suse.de> <20071112071448.GE22953@wotan.suse.de> <20071112071245.GB22953@wotan.suse.de> <6161.1194881354@redhat.com> <17445.1194913805@redhat.com> <18637.1194951385@redhat.com> <30440.1195042723@redhat.com> Cc: dhowells@redhat.com, Andrew Morton , linux-fsdevel@vger.kernel.org, mhalcrow@us.ibm.com, phillip@hellewell.homeip.net, sfrench@samba.org To: Nick Piggin Return-path: Received: from mx1.redhat.com ([66.187.233.31]:60589 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754431AbXKNP7U (ORCPT ); Wed, 14 Nov 2007 10:59:20 -0500 In-Reply-To: <20071114151825.GA20973@wotan.suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Nick Piggin wrote: > In core code, the PAGE_CACHE_SIZE is for page cache struct pages. Single > struct pages (not page arrays). Take a look at generic mapping read or > something. So you're saying a struct page controls an area of PAGE_CACHE_SIZE, not an area of PAGE_SIZE? Is a struct page then a purely pagecache concept? > Documentation is the opposite of convention ;) If it's not Documented, then it's irrelevant. David