From: Alexey Dobriyan <adobriyan@gmail.com>
To: brauner@kernel.org, frank.li@vivo.com
Cc: mcgrof@kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
Iurii Zaikin <yzaikin@google.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH] fs/drop_caches: move drop_caches sysctls into its own file
Date: Tue, 21 Mar 2023 17:37:10 +0300 [thread overview]
Message-ID: <226a6fc1-f6f4-4972-b76e-774094ffb821@p183> (raw)
> > +static struct ctl_table drop_caches_table[] = {
> > + {
> > + .procname = "drop_caches",
> > + .data = &sysctl_drop_caches,
> > + .maxlen = sizeof(int),
> > + .mode = 0200,
> > + .proc_handler = drop_caches_sysctl_handler,
> > + .extra1 = SYSCTL_ONE,
> > + .extra2 = SYSCTL_FOUR,
> > + },
> > + {}
> > +};
> > +
> > +static int __init drop_cache_init(void)
> > +{
> > + register_sysctl_init("vm", drop_caches_table);
>
> Does this belong under mm/ or fs/?
> And is it intended to be moved into a completely separate file?
> Feels abit wasteful for 20 lines of code...
It is better to keep all sysctls in one preallocated structure
for memory reasons:
header = kzalloc(sizeof(struct ctl_table_header) +
sizeof(struct ctl_node)*nr_entries, GFP_KERNEL_ACCOUNT);
next reply other threads:[~2023-03-21 14:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 14:37 Alexey Dobriyan [this message]
2023-03-21 16:42 ` [PATCH] fs/drop_caches: move drop_caches sysctls into its own file Luis Chamberlain
-- strict thread matches above, loose matches on Subject: below --
2023-03-21 13:09 Yangtao Li
2023-03-21 14:28 ` Christian Brauner
2023-03-21 16:39 ` Luis Chamberlain
2023-03-21 17:19 ` Christian Brauner
2023-03-21 16:42 ` Matthew Wilcox
2023-03-21 16:56 ` Luis Chamberlain
2023-03-21 17:19 ` Matthew Wilcox
2023-03-21 18:10 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=226a6fc1-f6f4-4972-b76e-774094ffb821@p183 \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=frank.li@vivo.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).