From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6B3B1E494 for ; Sat, 16 Dec 2023 20:51:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="p7hZXBtq" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6ce6f4d3dafso432819b3a.0 for ; Sat, 16 Dec 2023 12:51:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1702759880; x=1703364680; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UUxs9NMgV2od0wAPMGRXIqwkmFJ7SC5aOaZmQ30f1bI=; b=p7hZXBtqilk8a9Eo8gkmtxg0UZ6L2XB6ixBpI+aJs+DdnmyagfOqc+U1PcR/jbF8wD hwmmXv4Fce6qUIPfdnisRTnBUM9uiZRiouUpRG5qeO3pXcARGNiseYpdC1dFr8LGsxhT DR7LhPJgrKoLQucrfMXt57TbBGEZnmg1MssbFaiYDy86KoNXpNFcntGGZnlEPsO87XCR bgpBUToqUfWjJLHXZ+MzxqMffQ45nO7Qh6kWtXugW9tahIBQSc5SHHx86pkDHilUQ2Aa 8J15zdChSGfWiNTRLM+p+zw90Pg8aHln/Q/hXj7K8q9hjAnMh1Wz+qGeWoXSwajPFlqh PO2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702759880; x=1703364680; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UUxs9NMgV2od0wAPMGRXIqwkmFJ7SC5aOaZmQ30f1bI=; b=Z8VRgFpmWIGObHnsv2u/O8uoN4X+HepvvNAowCf1nunbwC2peanx0aO+j2MZT22/HK 2suDa3Q9FZorhRM9heA4j7oObj/7HS8Bc1/MdM1W2IgYw9Ilkiutefn67ymSI7VS6K1r CKyJtQbiHYkTUl8Cw+SYkfVoH6DgjmVjulHOlehuxwd56OY3dZNsLqcryVlAciSZuLys wZPbC3UinZHw5gdhen7uHFPODGsUTVqacO6aovSgMbQfzo4lgYGa+Blpqr7fIX9+QKXv M5Ok/f0n6iZZeS9U8MLYBUEWQ855rHXI5KYbbpcpi3PO8mRmwthmgi0UwrZUiY6X6dN+ X51g== X-Gm-Message-State: AOJu0Yxxpp8Gr32pBKckDZMVt9OAj+9Dcpd8PMO3ULqBBjBwZHD94dtD uLSxXkYjrqUGRwzG8kNCwT9JTzUUL7RsCV4PkM7Uzg== X-Google-Smtp-Source: AGHT+IFM41eA1W6KpzXbrZaSAx+vtqUc15fi/kSiO5Tuskzb7LXFKv1+yQZanPIuUHcpd55ejgIsVg== X-Received: by 2002:a05:6a00:460c:b0:6cd:dfff:19b6 with SMTP id ko12-20020a056a00460c00b006cddfff19b6mr29929295pfb.2.1702759879797; Sat, 16 Dec 2023 12:51:19 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.194]) by smtp.gmail.com with ESMTPSA id x6-20020aa784c6000000b006bd26bdc909sm15575923pfn.72.2023.12.16.12.51.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 Dec 2023 12:51:18 -0800 (PST) Message-ID: <226bdceb-e981-4a76-8912-bb5ec819ab78@kernel.dk> Date: Sat, 16 Dec 2023 13:51:17 -0700 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/14] Clean up the writeback paths Content-Language: en-US To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org References: <20231215200245.748418-1-willy@infradead.org> From: Jens Axboe In-Reply-To: <20231215200245.748418-1-willy@infradead.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/15/23 1:02 PM, Matthew Wilcox (Oracle) wrote: > I don't think any of this conflicts with the writeback refactoring that > Christoph has kindly taken over from me, although we might want to redo > patch 13 on that infrastructure rather than using write_cache_pages(). > That can be a later addition. > > Most of these patches verge on the trivial, converting filesystems that > just use block_write_full_page() to use mpage_writepages(). But as we > saw with Christoph's earlier patchset, there can be some "interesting" > gotchas, and I clearly haven't tested the majority of filesystems I've > touched here. > > Patches 3 & 4 get rid of a lot of stack usage on architectures with > larger page sizes; 1024 bytes on 64-bit systems with 64KiB pages. > It starts to open the door to larger folio sizes on all architectures, > but it's certainly not enough yet. > > Patch 14 is kind of trivial, but it's nice to get that simplification in. Series looks good to me: Reviewed-by: Jens Axboe -- Jens Axboe