From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH] CRED: Fix regression in cap_capable() as shown up by sys_faccessat() [ver #2] Date: Mon, 05 Jan 2009 15:57:03 +0000 Message-ID: <23397.1231171023@redhat.com> References: <20090102164505.GA10465@fieldses.org> <20090102051905.GC1073@fieldses.org> <20090101235332.GA31840@fieldses.org> <24959.1230694093@redhat.com> <20081230134248.GA30124@lst.de> <21275.1230736542@redhat.com> <29449.1230859152@redhat.com> <32481.1230897578@redhat.com> Cc: dhowells@redhat.com, Christoph Hellwig , jmorris@namei.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: "J. Bruce Fields" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:43759 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753948AbZAEP5Q (ORCPT ); Mon, 5 Jan 2009 10:57:16 -0500 In-Reply-To: <20090102164505.GA10465@fieldses.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: J. Bruce Fields wrote: > ... and I haven't figured out what's in between. And the test failure > is nfsd_lookup() returning OK on a directory when it should return > nfserr_perm. I assume that's the result of inode_permission(directory > inode, MAY_EXEC) returning 0 when it shouldn't, but I haven't confirmed > that. I appear to have reproduced this on my test machine. I'll have a poke around. David