From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Liu Aleaxander <aleaxander@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] vfs: does call expand_files when needed
Date: Wed, 18 Nov 2009 17:22:17 +0800 [thread overview]
Message-ID: <2375c9f90911180122p19030ea2gc395030178eb706d@mail.gmail.com> (raw)
In-Reply-To: <b741c2440911180054u1e610829g3646ec65701818ab@mail.gmail.com>
On Wed, Nov 18, 2009 at 4:54 PM, Liu Aleaxander <aleaxander@gmail.com> wrote:
<snip>
>
>>it's trivial, not so much an improvement, IMO.
> So, shouldn't we do the optimize when there is a way to do that?
>
> While, I don't think so. And BTW, it's not just a problem of
> optimization, but also make it be more sense: JUST call expand when
> need. I don't know why you are rejecting about this, especially it did
> optimized one call path(as you said), and it doesn't make the code
> uglier than before but making it be more sense, and, in fact, a kind
> of more readable.
I am not rejecting it, I said this is trivial, so accepting it or droping
it both are OK for me.
I don't think the orignal code is ugly, '< fdt->max_fds' is not checked
for expand_files(), but for find_next_zero_bit().
next prev parent reply other threads:[~2009-11-18 9:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 5:54 [PATCH] vfs: does call expand_files when needed Liu Aleaxander
2009-11-18 7:17 ` Américo Wang
2009-11-18 7:41 ` Liu Aleaxander
2009-11-18 8:35 ` Américo Wang
2009-11-18 8:54 ` Liu Aleaxander
2009-11-18 9:22 ` Américo Wang [this message]
2009-11-18 9:37 ` Liu Aleaxander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2375c9f90911180122p19030ea2gc395030178eb706d@mail.gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=aleaxander@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).