From: Marcel Ziswiler <marcel@ziswiler.com>
To: "Miklos Szeredi" <miklos@szeredi.hu>, "Jürg Billeter" <j@bitron.ch>
Cc: Matthew Wilcox <willy@infradead.org>,
linux-fsdevel@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: [REGRESSION] fuse: copy_file_range() fails with EIO
Date: Thu, 29 Aug 2024 11:27:43 +0200 [thread overview]
Message-ID: <23a1d750092f4ae85364ee73b8efa1c7653db86f.camel@ziswiler.com> (raw)
In-Reply-To: <CAJfpegtNF4yCH_00xzBB1OnPBHk+EP0ojxDPp=qCFVKC=c14ag@mail.gmail.com>
Hi Miklos
On Thu, 2024-08-22 at 15:32 +0200, Miklos Szeredi wrote:
> On Thu, 22 Aug 2024 at 15:14, Miklos Szeredi <miklos@szeredi.hu> wrote:
>
> > > > What I don't understand is how this results in the -EIO that Jürg
> > > > reported.
> > >
> > > I'm not really familiar with this code but it seems `folio_end_read()`
> > > uses xor to update the `PG_uptodate` flag. So if it was already set, it
> > > will incorrectly clear the `PG_uptodate` set, which I guess triggers
> > > the issue.
>
> Untested patch attached. Could you please try this?
Any progress on this? I can confirm that it does also fix an issue I noticed on Fedora Silverblue 40 running
6.10.6-200.fc40.x86_64. I successfully tested this patch on top of latest kernel-ark 6.11.0-
0.rc4.872cf28b8df9.39.fc40.x86_64. Thanks!
> Thanks,
> Miklos
Cheers
Marcel
next prev parent reply other threads:[~2024-08-29 9:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 15:53 [REGRESSION] fuse: copy_file_range() fails with EIO Jürg Billeter
2024-08-09 16:03 ` Matthew Wilcox
2024-08-09 16:22 ` [PATCH 1/3] fuse: remove call to SetPageError Matthew Wilcox (Oracle)
2024-08-09 16:22 ` [PATCH 2/3] fuse: Use a folio instead of a page Matthew Wilcox (Oracle)
2024-08-09 16:22 ` [PATCH 3/3] fuse: use folio_end_read Matthew Wilcox (Oracle)
2024-08-10 12:24 ` Jürg Billeter
2024-08-20 12:57 ` Jürg Billeter
2024-08-20 13:50 ` Matthew Wilcox
2024-08-22 11:58 ` Miklos Szeredi
2024-08-22 12:25 ` Matthew Wilcox
2024-08-10 5:56 ` [REGRESSION] fuse: copy_file_range() fails with EIO Jürg Billeter
2024-08-10 15:12 ` Matthew Wilcox
2024-08-22 13:04 ` Miklos Szeredi
2024-08-22 13:12 ` Jürg Billeter
2024-08-22 13:14 ` Miklos Szeredi
2024-08-22 13:32 ` Miklos Szeredi
2024-08-22 14:14 ` Jürg Billeter
2024-08-29 9:27 ` Marcel Ziswiler [this message]
2024-08-29 9:30 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23a1d750092f4ae85364ee73b8efa1c7653db86f.camel@ziswiler.com \
--to=marcel@ziswiler.com \
--cc=j@bitron.ch \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=regressions@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).