From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Howells <dhowells@redhat.com>
Subject: Re: [PATCH 14/14] NFS: Use local caching [try #2]
Date: Fri, 10 Aug 2007 15:04:40 +0100
Message-ID: <24071.1186754680@redhat.com>
References: <1186687557.6699.167.camel@heimdal.trondhjem.org>
	<1186683869.6699.136.camel@heimdal.trondhjem.org>
	<20070809160438.17906.76348.stgit@warthog.cambridge.redhat.com>
	<20070809160550.17906.40862.stgit@warthog.cambridge.redhat.com>
	<21984.1186685548@redhat.com>
Reply-To: Linux filesystem caching discussion list <linux-cachefs@redhat.com>
Cc: akpm@osdl.org, nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org,
	torvalds@osdl.org, linux-cachefs@redhat.com,
	linux-fsdevel@vger.kernel.org
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Return-path: <linux-cachefs-bounces@redhat.com>
In-Reply-To: <1186687557.6699.167.camel@heimdal.trondhjem.org>
List-Unsubscribe: <https://www.redhat.com/mailman/listinfo/linux-cachefs>,
	<mailto:linux-cachefs-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-cachefs>
List-Post: <mailto:linux-cachefs@redhat.com>
List-Help: <mailto:linux-cachefs-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-cachefs>,
	<mailto:linux-cachefs-request@redhat.com?subject=subscribe>
Sender: linux-cachefs-bounces@redhat.com
Errors-To: linux-cachefs-bounces@redhat.com
List-Id: linux-fsdevel.vger.kernel.org

Trond Myklebust <trond.myklebust@fys.uio.no> wrote:

> > > Dang, that's a lot of inlines... AFAICS, approx half of fs/nfs/fscache.h
> > > should really be moved into fscache.c.
> > 
> > If you wish.  It seems a shame since a lot of them have only one caller.
> 
> ...however it also forces you to export a lot of stuff which is really
> private to fscache.c (the atomics etc).

The atomics is actually a bad example.  These are referred to directly by part
of the table in fs/nfs/sysctl.c.  Is there a better way of exporting
statistics than through /proc/sys/ files?

David