From: Jeff Layton <jlayton@kernel.org>
To: Matthew Wilcox <willy@infradead.org>,
David Howells <dhowells@redhat.com>
Cc: ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/3] ceph: Uninline the data on a file opened for writing
Date: Mon, 17 Jan 2022 09:11:36 -0500 [thread overview]
Message-ID: <240e60443076a84c0599ccd838bd09c97f4cc5f9.camel@kernel.org> (raw)
In-Reply-To: <YeVzZZLcsX5Krcjh@casper.infradead.org>
On Mon, 2022-01-17 at 13:47 +0000, Matthew Wilcox wrote:
> On Mon, Jan 17, 2022 at 12:44:33PM +0000, David Howells wrote:
> > + if (ceph_caps_issued(ci) & (CEPH_CAP_FILE_CACHE|CEPH_CAP_FILE_LAZYIO)) {
> > + folio = filemap_get_folio(inode->i_mapping, 0);
> > + if (folio) {
> > + if (folio_test_uptodate(folio)) {
> > from_pagecache = true;
> > - lock_page(page);
> > + folio_lock(folio);
> > } else {
> > - put_page(page);
> > - page = NULL;
> > + folio_put(folio);
> > + folio = NULL;
>
> This all falls very much under "doing it the hard way", and quite
> possibly under the "actively buggy with races" category.
>
> read_mapping_folio() does what you want, as long as you pass 'filp'
> as your 'void *data'. I should fix that type ...
>
That would be nicer, I think. If you do that though, then patch #3
probably needs to come first in the series...
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2022-01-17 14:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 12:44 [PATCH 1/3] ceph: Uninline the data on a file opened for writing David Howells
2022-01-17 12:44 ` [PATCH 2/3] ceph: Remove some other inline-setting bits David Howells
2022-01-17 12:44 ` [PATCH 3/3] ceph: Make ceph_netfs_issue_op() handle inlined data (untested) David Howells
2022-01-17 13:47 ` [PATCH 1/3] ceph: Uninline the data on a file opened for writing Matthew Wilcox
2022-01-17 14:11 ` Jeff Layton [this message]
2022-01-17 14:27 ` David Howells
2022-01-17 14:30 ` Jeff Layton
2022-01-17 15:24 ` David Howells
2022-01-17 15:45 ` Jeff Layton
2022-01-17 15:57 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=240e60443076a84c0599ccd838bd09c97f4cc5f9.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).