From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CF3824336D; Wed, 25 Mar 2026 07:08:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774422514; cv=none; b=GkvqCiZFnazCMAhiofCezCTz5kHP1FqA5TrFkNrvfvqjabrV0r9bnbmNJpzEYAif1bh67mowGW477j1ocYvioaHltWdp6lKviaCjrP0zImikma4ubtzObfpa4Zt+7EcSigzZrl14qHPkVjzBJvMke6YneRtnE2QXGBOPJdi5hZM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774422514; c=relaxed/simple; bh=wloUbny5iGf241ZcwoWfGI1G4epwXCE04slEJFNkwPc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bdqAmkzBdJvrLyNXyP5zi4CjywHwiM8HdqgAfYgXECPEz+BJBYxbvzVaoazsvSaAXZr4mvDmxAOtNIGqMrCc+LU6NwPOsSoBnQZ0RT58DURwb5sU6vUyTwrss9aI16GLf9fJ4CYN9szyxCLCHRBDNQpzMKLfpeCbFL+6bzCTuEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U+fi7yjA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U+fi7yjA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C979DC2BC9E; Wed, 25 Mar 2026 07:08:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774422514; bh=wloUbny5iGf241ZcwoWfGI1G4epwXCE04slEJFNkwPc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U+fi7yjAY4ZcZaA8Wmq+9ofwJ01X6R5BUulVmOdBiUMiJNXdz/KWVyrUVBvzgPCdG 2iIJ4CGzZ7IBbErqBjmBCXGf1CFvx3+fKZ147WGar3VzjtyTzRvfbEBNSup+q0+J7b aPb6Ft2C7ojmFs8B8ou4LrMK94BCHWXKBqtTOB/U0rh+I+z+hMFm7l2vh+tpqjhKHZ E1o19EK9/Tp01KDDdBMfljviCTxMfaIATpKElMbeNcU09W7rcU882ncXoUehokpWFR /05zR6R0eEOzCsZDKcOave4LUSm3OuHObd65uQKuOZ1OkoMCXMj2iTdIe1ov7xt5cF KwF5Hpr6IdeEQ== Date: Wed, 25 Mar 2026 07:08:22 +0000 From: "Lorenzo Stoakes (Oracle)" To: Andrew Morton Cc: Arnd Bergmann , Greg Kroah-Hartman , Dan Williams , Vishal Verma , Dave Jiang , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , Muchun Song , Oscar Salvador , David Hildenbrand , Konstantin Komarov , Tony Luck , Reinette Chatre , Dave Martin , James Morse , Babu Moger , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Matthew Wilcox , Jan Kara , "Liam R . Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Hugh Dickins , Baolin Wang , Jann Horn , Pedro Falcato , Jason Gunthorpe , linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-mm@kvack.org, ntfs3@lists.linux.dev, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/6] mm: add vma_desc_test_all() and use it Message-ID: <24163ac9-bb0d-402c-a028-d1af7f56caa1@lucifer.local> References: <568c8f8d6a84ff64014f997517cba7a629f7eed6.1772704455.git.ljs@kernel.org> <20260324161212.4b0a6f4fd5eb57ff2ffa7ea5@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260324161212.4b0a6f4fd5eb57ff2ffa7ea5@linux-foundation.org> On Tue, Mar 24, 2026 at 04:12:12PM -0700, Andrew Morton wrote: > On Thu, 5 Mar 2026 10:50:15 +0000 "Lorenzo Stoakes (Oracle)" wrote: > > > erofs and zonefs are using vma_desc_test_any() twice to check whether all > > of VMA_SHARED_BIT and VMA_MAYWRITE_BIT are set, this is silly, so add > > vma_desc_test_all() to test all flags and update erofs and zonefs to use > > it. > > > > While we're here, update the helper function comments to be more > > consistent. > > > > Also add the same to the VMA test headers. > > fwiw, we have no review tags on this one. Based on the discussion we had about this previously I was under the impression if submitted by a maintainer that wasn't required? I'll nag people, but I'm a bit surprised if this is why you haven't moved this to mm-stable, given how trivially obviously correct this patch is. Lorenzo