* [PATCH 1/2] fs/namespace.c: fix kernel-doc warnings and add kernel-doc
@ 2020-01-31 5:25 Randy Dunlap
0 siblings, 0 replies; only message in thread
From: Randy Dunlap @ 2020-01-31 5:25 UTC (permalink / raw)
To: Linux FS Devel, Al Viro
From: Randy Dunlap <rdunlap@infradead.org>
Fix kernel-doc warnings in fs/namespace.c:
./fs/namespace.c:1309: warning: Function parameter or member 'm' not described in 'may_umount_tree'
./fs/namespace.c:1309: warning: Excess function parameter 'mnt' description in 'may_umount_tree'
./fs/namespace.c:1872: warning: Function parameter or member 'path' not described in 'clone_private_mount'
Also convert path_is_mountpoint() comments to kernel-doc.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
---
fs/namespace.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
--- linux-next-20200130.orig/fs/namespace.c
+++ linux-next-20200130/fs/namespace.c
@@ -1205,8 +1205,9 @@ struct vfsmount *mntget(struct vfsmount
}
EXPORT_SYMBOL(mntget);
-/* path_is_mountpoint() - Check if path is a mount in the current
- * namespace.
+/**
+ * path_is_mountpoint() - Check if path is a mount in the current namespace.
+ * @path: path to check
*
* d_mountpoint() can only be used reliably to establish if a dentry is
* not mounted in any namespace and that common case is handled inline.
@@ -1298,7 +1299,7 @@ const struct seq_operations mounts_op =
/**
* may_umount_tree - check if a mount tree is busy
- * @mnt: root of mount tree
+ * @m: root of mount tree
*
* This is called to check if a tree of mounts has any
* open files, pwds, chroots or sub mounts that are
@@ -1860,10 +1861,11 @@ void drop_collected_mounts(struct vfsmou
/**
* clone_private_mount - create a private clone of a path
+ * @path: path to clone
*
- * This creates a new vfsmount, which will be the clone of @path. The new will
- * not be attached anywhere in the namespace and will be private (i.e. changes
- * to the originating mount won't be propagated into this).
+ * This creates a new vfsmount, which will be the clone of @path. The new mount
+ * will not be attached anywhere in the namespace and will be private (i.e.
+ * changes to the originating mount won't be propagated into this).
*
* Release with mntput().
*/
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-01-31 5:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-31 5:25 [PATCH 1/2] fs/namespace.c: fix kernel-doc warnings and add kernel-doc Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).