linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Chris Dunlop <chris-s239Etu9j1dPR4JQBCEnsQ@public.gmane.org>,
	Al Viro <viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, "Myklebust,
	Trond" <Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>,
	linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Eric Van Hensbergen
	<ericvh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Ron Minnich <rminnich-4OHPYypu0djtX7QSmKvirg@public.gmane.org>,
	Latchesar Ionkov <lucho-OnYtXJJ0/fesTnJN9+BGXg@public.gmane.org>,
	Jan Harkes <jaharkes-ETDLCGt7PQU3uPMLIKxrzw@public.gmane.org>,
	"maintainer:CODA FILE SYSTEM"
	<coda-ETDLCGt7PQU3uPMLIKxrzw@public.gmane.org>,
	Dave Kleikamp <shaggy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Petr Vandrovec <petr-vPk2MGR0e28uaRcfnNAh7A@public.gmane.org>,
	Greg Kroah-Hartman <gregkh-l3A5Bk7waGM@public.gmane.org>,
	v9fs-developer-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-afs-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	codalist-OCorLXSLWn+MVn35/9/JlcWGCVk0P7UB@public.gmane.org,
	jfs-discussion-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/1] fix d_revalidate oopsen on NFS exports
Date: Wed, 30 Nov 2011 08:54:43 +0000	[thread overview]
Message-ID: <24960.1322643283@redhat.com> (raw)
In-Reply-To: <20111130071319.GA16711-s239Etu9j1dPR4JQBCEnsQ@public.gmane.org>

Chris Dunlop <chris-s239Etu9j1dPR4JQBCEnsQ@public.gmane.org> wrote:

> To avoid other people further wasting their and your time on
> exactly the same thing future, how something like the following
> patch, based on your comment in:
> 
> http://article.gmane.org/gmane.linux.nfs/40370
> 
> ...and, if that's acceptable, is it worthwhile doing for the
> other file systems which are likewise currently vulnerable when
> abused by broken layered file systems?

Also, this may get fixed by Al's atomic open patches - but obviously it hasn't
been yet...

> Don't oops when abused by broken layered file systems
> 
> Signed-off-by: Chris Dunlop <chris-s239Etu9j1dPR4JQBCEnsQ@public.gmane.org>

Acked-by: David Howells <dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

It's also worth printing a message - this *is* a kernel bug of some description
if it happens.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2011-11-30  8:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21  7:36 [PATCH 1/1] fix d_revalidate oopsen on NFS exports Chris Dunlop
     [not found] ` <1321861008-20611-1-git-send-email-chris-s239Etu9j1dPR4JQBCEnsQ@public.gmane.org>
2011-11-29  8:25   ` Chris Dunlop
     [not found]     ` <20111129082501.GA569-s239Etu9j1dPR4JQBCEnsQ@public.gmane.org>
2011-11-29 11:58       ` Myklebust, Trond
2011-11-30  7:13         ` Chris Dunlop
     [not found]         ` <20111130071319.GA16711-s239Etu9j1dPR4JQBCEnsQ@public.gmane.org>
2011-11-30  8:54           ` David Howells [this message]
2011-12-01  0:47             ` Chris Dunlop
2011-12-01  2:22               ` Dave Kleikamp
2011-12-01  3:33                 ` Chris Dunlop
2011-12-01  3:53                   ` Dave Kleikamp
2011-12-01  5:32                     ` Chris Dunlop
     [not found]               ` <20111201004709.GA26085-s239Etu9j1dPR4JQBCEnsQ@public.gmane.org>
2011-12-01  5:34                 ` Chris Dunlop
2011-12-01  6:31               ` Tyler Hicks
2011-12-01  7:29                 ` Chris Dunlop
2011-12-06 11:43                   ` Jacek Luczak
2011-12-01  6:50     ` Tyler Hicks
2011-12-01  7:23       ` Chris Dunlop
2011-12-01  8:02       ` Tyler Hicks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24960.1322643283@redhat.com \
    --to=dhowells-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
    --cc=chris-s239Etu9j1dPR4JQBCEnsQ@public.gmane.org \
    --cc=coda-ETDLCGt7PQU3uPMLIKxrzw@public.gmane.org \
    --cc=codalist-OCorLXSLWn+MVn35/9/JlcWGCVk0P7UB@public.gmane.org \
    --cc=ericvh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=gregkh-l3A5Bk7waGM@public.gmane.org \
    --cc=jaharkes-ETDLCGt7PQU3uPMLIKxrzw@public.gmane.org \
    --cc=jfs-discussion-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=linux-afs-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lucho-OnYtXJJ0/fesTnJN9+BGXg@public.gmane.org \
    --cc=petr-vPk2MGR0e28uaRcfnNAh7A@public.gmane.org \
    --cc=rminnich-4OHPYypu0djtX7QSmKvirg@public.gmane.org \
    --cc=shaggy-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=v9fs-developer-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).