linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: "Namjae Jeon" <namjae.jeon@samsung.com>
Cc: "'Namjae Jeon'" <linkinjeon@gmail.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	gregkh@linuxfoundation.org, sj1557.seo@samsung.com,
	pali.rohar@gmail.com, arnd@arndb.de, viro@zeniv.linux.org.uk,
	"'Christoph Hellwig'" <hch@lst.de>
Subject: Re: [PATCH] exfat: update file system parameter handling
Date: Wed, 05 Feb 2020 23:26:42 -0500	[thread overview]
Message-ID: <252365.1580963202@turing-police> (raw)
In-Reply-To: <003701d5db27$d3cd1ce0$7b6756a0$@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]

On Tue, 04 Feb 2020 15:53:38 +0900, "Namjae Jeon" said:
> > > Al Viro recently reworked the way file system parameters are handled
> > > Update super.c to work with it in linux-next 20200203.

> Acked-by: Namjae Jeon <namjae.jeon@samsung.com>
>
> If I need to make v14 patch series for this, Let me know it.

Hmm... That's a process/git question that somebody else (probably Al Viro) will
have to answer.

fs/exfat/super.c won't compile on next-20200203 or later without the patch, and
as a practical matter the version that finally goes into the main tree will need the patch.

On the one hand, the proper way to track the history of that patch would be to
cherry-pick it into the proper spot in your patch series, right after the
commit that adds super.c.  Then the git history reflects what code came from
where.

On the other hand, it leaves a really small window where a git bisect can land
exactly on the commit that adds the unpatched version of super.c and fail to
buiild.  If all the Signed-off-by's were from one person, the obvious answer is
to fold the fix into the commit that adds super.c - but that loses the git
history.

So I'm going to dodge the question by saying "What would Al Viro do?" :)





[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2020-02-06  4:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-04  3:24 [PATCH] exfat: update file system parameter handling Valdis Klētnieks
2020-02-04  6:06 ` Christoph Hellwig
2020-02-04  6:53   ` Namjae Jeon
2020-02-06  4:26     ` Valdis Klētnieks [this message]
2020-02-06  6:54       ` Al Viro
2020-02-08  2:02         ` Linus Torvalds
2020-02-08  3:42           ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=252365.1580963202@turing-police \
    --to=valdis.kletnieks@vt.edu \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=linkinjeon@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namjae.jeon@samsung.com \
    --cc=pali.rohar@gmail.com \
    --cc=sj1557.seo@samsung.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).