From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Petr Vandrovec" Subject: Re: [PATCH] centralize some nls helpers Date: Wed, 1 Sep 2004 16:15:38 +0200 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <253871B35E8@vcnet.vc.cvut.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Cc: linux-fsdevel@vger.kernel.org Return-path: Received: from mailgw.cvut.cz ([147.32.3.235]:41166 "EHLO mailgw.cvut.cz") by vger.kernel.org with ESMTP id S266666AbUIAOPd (ORCPT ); Wed, 1 Sep 2004 10:15:33 -0400 To: Christoph Hellwig List-Id: linux-fsdevel.vger.kernel.org On 1 Sep 04 at 11:50, Christoph Hellwig wrote: > This patch adds common nls_tolower, nls_toupper and nls_strnicmp helpers > to nls.h and uses them in various filesystems instead of local > duplicates. > > The situation for ncpfs isn't as nice as it allows to compile without > nls support even if the kernel has CONFIG_NLS set, so we need wrappers > there. I have no problem with setting CONFIG_NCPFS_NLS == CONFIG_NLS. As all ncpfs features except NCPFS_SMALLDOS can be set at mount time, there is no reason for not hardwiring all CONFIG_NCPFS_* options (except SMALLDOS) to 'y', except that it will consume some additional memory (and I doubt that embedded people use ncpfs). Only question is whether retain CONFIG_NCP_FS selecting NLS (currently CONFIG_NCPFS_NLS selects NLS), or whether CONFIG_NCP_FS should depend on NLS (I've thought that CONFIG_NCPFS_NLS depends on NLS and only just now I found that CONFIG_NCPFS_NLS selects NLS now...). Petr Vandrovec vandrove@vc.cvut.cz