From: Valdis.Kletnieks@vt.edu
To: Nick Piggin <npiggin@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
Joel Becker <joel.becker@oracle.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: 2.6.37-next - kernel BUG at fs/dcache.c:1363
Date: Fri, 07 Jan 2011 12:10:40 -0500 [thread overview]
Message-ID: <25743.1294420240@localhost> (raw)
In-Reply-To: Your message of "Fri, 07 Jan 2011 00:12:09 +1100." <AANLkTi=nVJNJdBChyuD43sqWEf3O_1tDj0FTO8O_Ukib@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On Fri, 07 Jan 2011 00:12:09 +1100, Nick Piggin said:
> > Thanks. It actually passed in a dentry that appears to have already been
> > used for something. This is not exactly a nice thing for a filesystem to do
> > and probably indicates an underlying bug anyway (or at least something
> > the vfs doesn't guarantee the safety of).
> >
> > Taking a look now.
>
> This patch fixes it here
> config fs: avoid switching ->d_op on live dentry
> Switching d_op on a live dentry is racy in general, so avoid it. In this case
> it is a negative dentry, which is safer, but there are still concurrent ops
> which may be called on d_op in that case (eg. d_revalidate). So in general
> a filesystem may not do this. Fix configfs so as not to do this.
Confirming this patch fixes the crash I was seeing, so now I'm off to try to
finish bisecting my way through the other issue I was seeing...
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
prev parent reply other threads:[~2011-01-07 17:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 17:15 2.6.37-next - kernel BUG at fs/dcache.c:1363 Valdis.Kletnieks
2011-01-06 10:44 ` Nick Piggin
2011-01-06 13:12 ` Nick Piggin
2011-01-07 17:10 ` Valdis.Kletnieks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25743.1294420240@localhost \
--to=valdis.kletnieks@vt.edu \
--cc=joel.becker@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).