From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 00/18] Introduce automount support in the VFS [ver #4] Date: Fri, 14 Jan 2011 11:54:48 +0000 Message-ID: <2591.1295006088@redhat.com> References: <2443.1295005428@redhat.com> <20110114070224.GB19804@ZenIV.linux.org.uk> <20110113215359.19406.37232.stgit@warthog.procyon.org.uk> Cc: dhowells@redhat.com, Al Viro , raven@themaw.net, npiggin@kernel.dk, autofs@linux.kernel.org, linux-fsdevel@vger.kernel.org To: unlisted-recipients:; (no To-header on input) Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54709 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751473Ab1ANLy7 (ORCPT ); Fri, 14 Jan 2011 06:54:59 -0500 In-Reply-To: <2443.1295005428@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: David Howells wrote: > It would be simpler, perhaps, to allow d_automount() to return the list also: > > struct vfsmount *(*d_automount)(struct path *mountpoint, > struct list_head **expiry_list_to_use); > > This pointer can then be passed directly to do_add_mount() and we don't have > to worry about having an extra reference or cleaning up the list on error. However, that isn't good enough as the filesystem may also need to start up the time-based expirer, which in the case of AFS, NFS and CIFS doesn't repeat if the list is empty - so if the mounting process gets preempted... David