Re[2]: Corrupted ASFS patch.

Re[2]: Corrupted ASFS patch.

[Pavel Fedin]

Hello maximilian,

Monday, February 9, 2009, 4:31:20 PM, you wrote:

> as debian linux-2.6 maintainer we used to have this fs, but dropped as
> the author showed no will or sign to go upstream.
> the small but important critic does need to get worked on.

 Hm, he told me the opposite thing...
 Well, at least I am interested in merging it into the kernel. Well,
i'll try to get things fixed (however i don't have much time to do
it).

> so if you wana help to get this somewhere get the fs fixed and
> properly send in patches.

 First, i've worked around my company's firewall and now i'm at last able to
use e-mail client for sending messages again. :-)
 Second, sorry for re-posting the patch (it was still laying in The
Bat's outbox and when i pressed 'Send mail' it was succesfully sent.
Well, at least this would let you to review the patch better...
 Third, this is the question fot Matthew, about annotating endianess
in on-disk structures. What if the filesystem is bi-endian? Original
SFS (http://sourceforge.net/projects/smartfilesystem) is bi-endian. I
still don't know how much of support for little-endian version is implemented
in Linux version.

-- 
Best regards,
 Pavel                            mailto:sonic.amiga@gmail.com

Re[2]: Corrupted ASFS patch.

[Pavel Fedin]

Hello Phillip,

Thursday, February 12, 2009, 12:42:42 PM, you wrote:

> As SFS is not a native Linux filesystem you could argue that the
> bi-endian layout is a legacy feature over which you have no control.
> However, unless there are a lot of little-endian SFS filesystems
> out there, supporting them is likely to give you more pain than
> it's worth, and it will present an additional barrier to mainlining.

 I've asked Michal Schulz at AROS IRC channel, he told me that
little-endian version was introduced as experimental and it did not
gave any significant speedup (just 1%). This ended its life - support
for little-endian SFS exists only in theory, it is not adviced for
production use, not supported by formatting and installation tools,
etc.
 So far the issue is closed. SFS is bigendian. End of story.
 Do i understand right that i just need to replace all 'uXX' with
'beXX' in on-disk structures definition ?


-- 
Best regards,
 Pavel                            mailto:sonic.amiga@gmail.com

Re[2]: Corrupted ASFS patch.

[Pavel Fedin]

Hello Phillip,

Thursday, February 12, 2009, 7:38:04 PM, you wrote:

> Yes, replace all uXX with __beXX in on-disk structures.

 Done. Take it.

-- 
Best regards,
 Pavel                            mailto:sonic.amiga@gmail.com