From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com ([134.134.136.126]:2596 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725830AbeJLHRg (ORCPT ); Fri, 12 Oct 2018 03:17:36 -0400 Subject: Re: [PATCH v2 4/7] arm64/modules: Add rlimit checking for arm64 modules To: Rick Edgecombe , kernel-hardening@lists.openwall.com, daniel@iogearbox.net, keescook@chromium.org, catalin.marinas@arm.com, will.deacon@arm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, arnd@arndb.de, jeyu@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org References: <20181011233117.7883-1-rick.p.edgecombe@intel.com> <20181011233117.7883-5-rick.p.edgecombe@intel.com> Cc: kristen@linux.intel.com, arjan@linux.intel.com, deneen.t.dock@intel.com From: Dave Hansen Message-ID: <25951d99-8ba7-5c9e-938e-baf92395f9e0@intel.com> Date: Thu, 11 Oct 2018 16:47:29 -0700 MIME-Version: 1.0 In-Reply-To: <20181011233117.7883-5-rick.p.edgecombe@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 10/11/2018 04:31 PM, Rick Edgecombe wrote: > + if (check_inc_mod_rlimit(size)) > + return NULL; > + > p = __vmalloc_node_range(size, MODULE_ALIGN, module_alloc_base, > module_alloc_base + MODULES_VSIZE, > gfp_mask, PAGE_KERNEL_EXEC, 0, > @@ -65,6 +68,8 @@ void *module_alloc(unsigned long size) > return NULL; > } > > + update_mod_rlimit(p, size); Is there a reason we couldn't just rename all of the existing per-arch module_alloc() calls to be called, say, "arch_module_alloc()", then put this new rlimit code in a generic helper that does: if (check_inc_mod_rlimit(size)) return NULL; p = arch_module_alloc(...); ... update_mod_rlimit(p, size);