From: corbet@lwn.net (Jonathan Corbet)
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: alan@redhat.com, viro@zeniv.linux.org.uk, hch@infradead.org,
peterz@infradead.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC/PATCH 2/8] revoke: inode revoke lock V7
Date: Tue, 18 Dec 2007 09:31:49 -0700 [thread overview]
Message-ID: <2605.1197995509@vena.lwn.net> (raw)
In-Reply-To: Your message of "Fri, 14 Dec 2007 17:16:17 +0200." <Pine.LNX.4.64.0712141715440.28689@sbz-30.cs.Helsinki.FI>
This is a relatively minor detail in the rather bigger context of this
patch, but...
> @@ -642,6 +644,7 @@ struct inode {
> struct list_head inotify_watches; /* watches on this inode */
> struct mutex inotify_mutex; /* protects the watches list */
> #endif
> + wait_queue_head_t i_revoke_wait;
That seems like a relatively hefty addition to every inode in the system
when revoke - I think - will be a fairly rare operation. Would there be
any significant cost to using a single, global revoke-wait queue instead
of growing the inode structure?
jon
next prev parent reply other threads:[~2007-12-18 16:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 15:16 [RFC/PATCH 2/8] revoke: inode revoke lock V7 Pekka J Enberg
2007-12-17 22:28 ` serge
2007-12-18 7:31 ` Pekka J Enberg
2007-12-19 15:30 ` Serge E. Hallyn
2007-12-19 20:23 ` Pekka J Enberg
2007-12-19 20:30 ` Serge E. Hallyn
2007-12-18 16:31 ` Jonathan Corbet [this message]
2007-12-19 9:02 ` Pekka J Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2605.1197995509@vena.lwn.net \
--to=corbet@lwn.net \
--cc=alan@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).