From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 2/3] EXPORTFS: Have fh_to_*() return -ESTALE if the file handle type is unrecognised [try #2] Date: Fri, 05 Dec 2008 09:14:24 +0000 Message-ID: <26187.1228468464@redhat.com> References: <20081204193102.GC7575@fieldses.org> <20081203183033.2636.47937.stgit@warthog.procyon.org.uk> <20081203183038.2636.74428.stgit@warthog.procyon.org.uk> Cc: dhowells@redhat.com, hch@infradead.org, viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org To: "J. Bruce Fields" Return-path: Received: from mx2.redhat.com ([66.187.237.31]:44894 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbYLEJO2 (ORCPT ); Fri, 5 Dec 2008 04:14:28 -0500 In-Reply-To: <20081204193102.GC7575@fieldses.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: J. Bruce Fields wrote: > It looks like d_obtain_alias already returns -ESTALE in this case, not a > negative dentry. Sorry, you're right. I should know that. This patch is superfluous, though it may give better performance in the duff-handle case. David