From: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sasha Levin <alexander.levin@microsoft.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/staging/exfat - by default, prohibit mount of fat/vfat
Date: Fri, 30 Aug 2019 20:48:36 -0400 [thread overview]
Message-ID: <267691.1567212516@turing-police> (raw)
In-Reply-To: <20190830164503.GA12978@infradead.org>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=us-ascii, Size: 1420 bytes --]
On Fri, 30 Aug 2019 09:45:03 -0700, Christoph Hellwig said:
> On Fri, Aug 30, 2019 at 12:42:39PM -0400, Valdis Klētnieks wrote:
> > Concerns have been raised about the exfat driver accidentally mounting
> > fat/vfat file systems. Add an extra configure option to help prevent that.
>
> Just remove that code. This is exactly what I fear about this staging
> crap, all kinds of half-a***ed patches instead of trying to get anything
Explain how it's half-a**ed. You worry about accidental mounting, meanwhile
down in the embedded space there are memory-constrained machines that
don't want separate vfat and exfat drivers sitting around in memory. If you
have a better patch that addresses both concerns, feel free to submit it.
> done. Given that you signed up as the maintainer for this what is your
> plan forward on it? What development did you on the code and what are
> your next steps?
Well, the *original* plan was to get it into the tree someplace so it can get
review and updates from others. Given the amount of press the Microsoft
announcement had, we were *hoping* there would be some momentum and
people actually looking at the code and feeding me patches. I've gotten a
half dozen already today....
Although if you prefer, it can just sit out-of-tree until I've got a perfect driver
without input or review from anybody. But I can't think of *any* instance where
that model has actually worked.
[-- Attachment #2: Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2019-08-31 0:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 16:42 [PATCH] drivers/staging/exfat - by default, prohibit mount of fat/vfat Valdis Klētnieks
2019-08-30 16:45 ` Christoph Hellwig
2019-08-31 0:48 ` Valdis Klētnieks [this message]
2019-08-31 6:46 ` Christoph Hellwig
2019-08-31 10:25 ` Valdis Klētnieks
2019-08-31 14:24 ` Andy Shevchenko
2019-08-31 14:51 ` Valdis Klētnieks
2019-09-01 1:07 ` Dave Chinner
2019-09-01 1:37 ` Gao Xiang
2019-09-01 3:05 ` Al Viro
2019-09-01 3:26 ` Gao Xiang
2019-09-01 3:37 ` Valdis Klētnieks
2019-09-01 22:43 ` Dave Chinner
2019-09-01 23:13 ` Valdis Klētnieks
2019-09-02 7:38 ` Christoph Hellwig
2019-09-02 7:35 ` Christoph Hellwig
2019-09-02 15:25 ` Greg Kroah-Hartman
2019-09-02 19:00 ` Valdis Klētnieks
2019-09-02 19:06 ` Greg Kroah-Hartman
2019-09-08 10:50 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=267691.1567212516@turing-police \
--to=valdis.kletnieks@vt.edu \
--cc=alexander.levin@microsoft.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).