From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 19/19] BLOCK: Make it possible to disable the block layer [try #6] Date: Wed, 30 Aug 2006 21:13:12 +0100 Message-ID: <26780.1156968792@warthog.cambridge.redhat.com> References: <20060830124400.23ca9b38.akpm@osdl.org> <20060829180552.32596.15290.stgit@warthog.cambridge.redhat.com> <20060829180634.32596.4507.stgit@warthog.cambridge.redhat.com> Cc: David Howells , axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from mx1.redhat.com ([66.187.233.31]:5809 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1751475AbWH3UNW (ORCPT ); Wed, 30 Aug 2006 16:13:22 -0400 In-Reply-To: <20060830124400.23ca9b38.akpm@osdl.org> To: Andrew Morton Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Andrew Morton wrote: > I think I'll just slam all this in at the first opportunity. Stuff will > break, but it will be easy to fix. Well, it's into Jens's block GIT tree. > If you try to upissue this patchset I shall be seeking an IP-routable hand > grenade. "upissue"? > This function is misnamed and is implemented in the wrong place. It's not > really a block thing at all. If/when/soon NFS starts to implement it and > call it, things will need to be renamed and reshuffled. Sounds this function then migrate to kernel/sched.c along with its baggage train. > So... for now, I'll replace it with a simple io_schedule_timeout(timeout), > which is equivalent to what we do now for network filesystems. Please send the patch to Jens to make sure the block GIT tree gets fixed. David