From: "J. R. Okajima" <hooanon05g@gmail.com>
To: ZhangXiaoxu <zhangxiaoxu5@huawei.com>,
Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: linux-fsdevel@vger.kernel.org
Subject: Q. set_cached_acl() on NFSv3
Date: Sun, 24 Mar 2019 11:46:01 +0900 [thread overview]
Message-ID: <26927.1553395561@jrobl> (raw)
By the commit for v5.1-rc1,
ded52fbe7020 2019-02-20 nfs: fix xfstest generic/099 failed on nfsv3
NFSv3 stopped calling set_cached_acl().
And the behaviour changed. Is this intentional?
Here is the example.
(test script)
f=fileA
> $f
getfacl --omit-header $f |
tee $tmp
setfacl -m u:$USER:rx,g:nogroup:x $f
getfacl --omit-header $f |
diff -u $tmp - || :
setfacl -x u:$USER,g:nogroup $f
getfacl --omit-header $f |
diff -u $tmp - || :
- on linux-v5.0, there is no difference between ext4 and nfs3.
- on linux-v5.1-rc1, ext4 behaves same, but nfs3 doesn't show the "mask"
entry in the last output.
- removing user:$USER and group:nogroup entries looks "mask" entry gone
too.
J. R. Okajima
########################################
linux-v5.0
ext4
+ getfacl --omit-header fileA
+ tee /tmp/6311
user::rw-
group::r--
other::r--
+ setfacl -m u:jro:rx,g:nogroup:x fileA
+ getfacl --omit-header fileA
+ diff -u /tmp/6311 -
--- /tmp/6311 2019-03-24 11:16:18.000000000 +0900
+++ - 2019-03-24 11:16:18.053867096 +0900
@@ -1,4 +1,7 @@
user::rw-
+user:jro:r-x
group::r--
+group:nogroup:--x
+mask::r-x
other::r--
+ setfacl -x u:jro,g:nogroup fileA
+ getfacl --omit-header fileA
+ diff -u /tmp/6311 -
--- /tmp/6311 2019-03-24 11:16:18.000000000 +0900
+++ - 2019-03-24 11:16:18.062265271 +0900
@@ -1,4 +1,5 @@
user::rw-
group::r--
+mask::r--
other::r--
########################################
linux-v5.0
nfs3
+ getfacl --omit-header fileA
+ tee /tmp/6579
user::rw-
group::r--
other::r--
+ setfacl -m u:jro:rx,g:nogroup:x fileA
+ getfacl --omit-header fileA
+ diff -u /tmp/6579 -
--- /tmp/6579 2019-03-24 11:16:27.000000000 +0900
+++ - 2019-03-24 11:16:27.360407625 +0900
@@ -1,4 +1,7 @@
user::rw-
+user:jro:r-x
group::r--
+group:nogroup:--x
+mask::r-x
other::r--
+ :
+ setfacl -x u:jro,g:nogroup fileA
+ getfacl --omit-header fileA
+ diff -u /tmp/6579 -
--- /tmp/6579 2019-03-24 11:16:27.000000000 +0900
+++ - 2019-03-24 11:16:27.369262067 +0900
@@ -1,4 +1,5 @@
user::rw-
group::r--
+mask::r--
other::r--
########################################
linux-v5.1-rc1
ext4
+ f=fileA
+
+ getfacl --omit-header fileA
+ tee /tmp/2065
user::rw-
group::r--
other::r--
+ setfacl -m u:jro:rx,g:nogroup:x fileA
+ getfacl --omit-header fileA
+ diff -u /tmp/2065 -
--- /tmp/2065 2019-03-24 11:19:24.000000000 +0900
+++ - 2019-03-24 11:19:24.223903353 +0900
@@ -1,4 +1,7 @@
user::rw-
+user:jro:r-x
group::r--
+group:nogroup:--x
+mask::r-x
other::r--
+ :
+ setfacl -x u:jro,g:nogroup fileA
+ getfacl --omit-header fileA
+ diff -u /tmp/2065 -
--- /tmp/2065 2019-03-24 11:19:24.000000000 +0900
+++ - 2019-03-24 11:19:24.230741358 +0900
@@ -1,4 +1,5 @@
user::rw-
group::r--
+mask::r--
other::r--
########################################
linux-v5.1-rc1
nfs3
+ f=fileA
+
+ getfacl --omit-header fileA
+ tee /tmp/2351
user::rw-
group::r--
other::r--
+ setfacl -m u:jro:rx,g:nogroup:x fileA
+ getfacl --omit-header fileA
+ diff -u /tmp/2351 -
--- /tmp/2351 2019-03-24 11:19:30.000000000 +0900
+++ - 2019-03-24 11:19:30.706744795 +0900
@@ -1,4 +1,7 @@
user::rw-
+user:jro:r-x
group::r--
+group:nogroup:--x
+mask::r-x
other::r--
+ :
+ setfacl -x u:jro,g:nogroup fileA
+ getfacl --omit-header fileA
+ diff -u /tmp/2351 -
(there is no diff output)
reply other threads:[~2019-03-24 2:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26927.1553395561@jrobl \
--to=hooanon05g@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=zhangxiaoxu5@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).