From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62164C43381 for ; Mon, 18 Mar 2019 23:01:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 315982171F for ; Mon, 18 Mar 2019 23:01:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727000AbfCRXBQ convert rfc822-to-8bit (ORCPT ); Mon, 18 Mar 2019 19:01:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60854 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726896AbfCRXBQ (ORCPT ); Mon, 18 Mar 2019 19:01:16 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 43C3C309178C for ; Mon, 18 Mar 2019 23:01:16 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-17.rdu2.redhat.com [10.10.120.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7D6B96B48D; Mon, 18 Mar 2019 23:01:13 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <8b0534dc-0ee0-ba7f-8709-30433c04c5a7@redhat.com> References: <8b0534dc-0ee0-ba7f-8709-30433c04c5a7@redhat.com> <20190317174027.15291-2-anprice@redhat.com> <20190317174027.15291-1-anprice@redhat.com> <28293.1552915099@warthog.procyon.org.uk> To: Andrew Price Cc: dhowells@redhat.com, cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/2] gfs2: Convert gfs2 to fs_context MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <27151.1552950072.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Mon, 18 Mar 2019 23:01:12 +0000 Message-ID: <27152.1552950072@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Mon, 18 Mar 2019 23:01:16 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Andrew Price wrote: > > Umm... What about the fs_context struct? Why can't that be used to > > propagate the bdev pointer? That's kind of what it's for... > > It would be useful to have the block device pointer in the fs_context since so > many of the filesystems use them and it makes for an obvious API migration. That may be so. I've argued also that we should put a net-namespace pointer in there, but Al disagreed. However, I think most bdev-based filesystems use mount_bdev() which gfs2 does not. > > It looks like you should be able to stash the bdev pointer in the gfs2_args > > struct. > > Sure, but since the new API is young I figured I'd hold off until we had this > conversation because adding it to the fs_context might be agreeable :) Note that I have patches to kill of sget_userns() and sget() will hopefully soon follow. Have a look at: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=mount-api-viro David