From: David Howells <dhowells@redhat.com>
To: James Morris <jmorris@namei.org>
Cc: Trond.Myklebust@netapp.com, nfsv4@linux-nfs.org,
linux-kernel@vger.kernel.org, dhowells@redhat.com,
linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 07/37] Security: De-embed task security record from task and use refcounting
Date: Mon, 11 Feb 2008 17:30:36 +0000 [thread overview]
Message-ID: <28534.1202751036@redhat.com> (raw)
In-Reply-To: <Xine.LNX.4.64.0802112156030.27028@us.intercode.com.au>
James Morris <jmorris@namei.org> wrote:
> > Remove the temporarily embedded task security record from task_struct.
> > Instead it is made to dangle from the task_struct::sec and
> > task_struct::act_as pointers with references counted for each.
>
> ...
>
> These patches are kind of huge.
Yeah, I know. The problem is that each patch must compile and run. They
can't be split up without violating that unfortunately.
> Why manually copy these fields after a kmemdup?
Fair point. Fixed.
> What about the task backpointer? (i.e. tsec2->task)
The problem is that there can't be one with this patch as the task_security
struct and the LSM security data attached to it may outlive the task it points
back to.
It seems that the backpointer can be dispensed with. Nothing particularly
seems to use it. Do you know the reason for its existence?
David
next prev parent reply other threads:[~2008-02-11 17:30 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 16:51 [PATCH 00/37] Permit filesystem local caching David Howells
2008-02-08 16:52 ` [PATCH 01/37] KEYS: Increase the payload size when instantiating a key David Howells
2008-02-08 16:52 ` [PATCH 02/37] KEYS: Check starting keyring as part of search David Howells
2008-02-08 16:52 ` [PATCH 03/37] KEYS: Allow the callout data to be passed as a blob rather than a string David Howells
2008-02-08 16:52 ` [PATCH 04/37] KEYS: Add keyctl function to get a security label David Howells
2008-02-08 16:52 ` [PATCH 05/37] Security: Change current->fs[ug]id to current_fs[ug]id() David Howells
2008-02-11 10:38 ` James Morris
2008-02-08 16:52 ` [PATCH 06/37] Security: Separate task security context from task_struct David Howells
2008-02-11 10:43 ` James Morris
2008-02-08 16:52 ` [PATCH 07/37] Security: De-embed task security record from task and use refcounting David Howells
2008-02-11 10:57 ` James Morris
2008-02-11 17:30 ` David Howells [this message]
2008-02-11 18:48 ` Stephen Smalley
2008-02-08 16:52 ` [PATCH 08/37] Security: Add a kernel_service object class to SELinux David Howells
2008-02-11 10:59 ` James Morris
2008-02-08 16:52 ` [PATCH 09/37] Security: Allow kernel services to override LSM settings for task actions David Howells
2008-02-08 16:52 ` [PATCH 10/37] Security: Make NFSD work with detached security David Howells
2008-02-08 16:52 ` [PATCH 11/37] FS-Cache: Release page->private after failed readahead David Howells
2008-02-08 16:53 ` [PATCH 12/37] FS-Cache: Recruit a couple of page flags for cache management David Howells
2008-02-08 16:53 ` [PATCH 13/37] FS-Cache: Provide an add_wait_queue_tail() function David Howells
2008-02-08 16:53 ` [PATCH 14/37] FS-Cache: Generic filesystem caching facility David Howells
2008-02-08 16:53 ` [PATCH 15/37] CacheFiles: Add missing copy_page export for ia64 David Howells
2008-02-08 16:53 ` [PATCH 16/37] CacheFiles: Be consistent about the use of mapping vs file->f_mapping in Ext3 David Howells
2008-02-08 16:53 ` [PATCH 17/37] CacheFiles: Add a hook to write a single page of data to an inode David Howells
2008-02-08 16:53 ` [PATCH 18/37] CacheFiles: Permit the page lock state to be monitored David Howells
2008-02-08 16:53 ` [PATCH 19/37] CacheFiles: Export things for CacheFiles David Howells
2008-02-08 16:53 ` [PATCH 20/37] CacheFiles: A cache that backs onto a mounted filesystem David Howells
2008-02-08 16:53 ` [PATCH 21/37] NFS: Add comment banners to some NFS functions David Howells
2008-02-08 16:53 ` [PATCH 22/37] NFS: Add FS-Cache option bit and debug bit David Howells
2008-02-08 16:54 ` [PATCH 23/37] NFS: Permit local filesystem caching to be enabled for NFS David Howells
2008-02-08 16:54 ` [PATCH 24/37] NFS: Register NFS for caching and retrieve the top-level index David Howells
2008-02-08 16:54 ` [PATCH 25/37] NFS: Define and create server-level objects David Howells
2008-02-08 16:54 ` [PATCH 26/37] NFS: Define and create superblock-level objects David Howells
2008-02-08 16:54 ` [PATCH 27/37] NFS: Define and create inode-level cache objects David Howells
2008-02-08 16:54 ` [PATCH 28/37] NFS: Use local disk inode cache David Howells
2008-02-08 16:54 ` [PATCH 29/37] NFS: Invalidate FsCache page flags when cache removed David Howells
2008-02-08 16:54 ` [PATCH 30/37] NFS: Add some new I/O event counters for FS-Cache events David Howells
2008-02-08 16:54 ` [PATCH 31/37] NFS: FS-Cache page management David Howells
2008-02-08 16:54 ` [PATCH 32/37] NFS: Add read context retention for FS-Cache to call back with David Howells
2008-02-08 16:54 ` [PATCH 33/37] NFS: nfs_readpage_async() needs to be accessible as a fallback for local caching David Howells
2008-02-08 16:54 ` [PATCH 34/37] NFS: Read pages from FS-Cache into an NFS inode David Howells
2008-02-08 16:55 ` [PATCH 35/37] NFS: Store pages from an NFS inode into a local cache David Howells
2008-02-08 16:55 ` [PATCH 36/37] NFS: Display local caching state David Howells
2008-02-08 16:55 ` [PATCH 37/37] NFS: Add mount options to enable local caching on NFS David Howells
-- strict thread matches above, loose matches on Subject: below --
2008-02-20 16:05 [PATCH 00/37] Permit filesystem local caching David Howells
2008-02-20 16:06 ` [PATCH 07/37] Security: De-embed task security record from task and use refcounting David Howells
2008-02-22 4:57 ` Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28534.1202751036@redhat.com \
--to=dhowells@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).