From: David Howells <dhowells@redhat.com>
To: hongao <hongao@uniontech.com>
Cc: dhowells@redhat.com, Paulo Alcantara <pc@manguebit.org>,
netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+3c74b1f0c372e98efc32@syzkaller.appspotmail.com
Subject: Re: [PATCH] netfs: Fix UAF in netfs_unbuffered_write() on failed preparation
Date: Tue, 23 Jun 2026 15:53:53 +0100 [thread overview]
Message-ID: <2877069.1782226433@warthog.procyon.org.uk> (raw)
In-Reply-To: <FA1EF9EEE4C1415E+20260530011403.1686344-1-hongao@uniontech.com>
hongao <hongao@uniontech.com> wrote:
> /* Check if (re-)preparation failed. */
> if (unlikely(test_bit(NETFS_SREQ_FAILED, &subreq->flags))) {
> - netfs_write_subrequest_terminated(subreq, subreq->error);
> - wreq->error = subreq->error;
> + ret = subreq->error;
> + wreq->error = ret;
> + netfs_write_subrequest_terminated(subreq, ret);
> break;
> }
This shouldn't be effective as all netfs_write_subrequest_terminated() will do
is pass control of the subreq struct back to the app thread.
David
prev parent reply other threads:[~2026-06-23 14:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 1:14 [PATCH] netfs: Fix UAF in netfs_unbuffered_write() on failed preparation hongao
2026-06-23 10:28 ` Christian Brauner
2026-06-23 11:52 ` ChenXiaoSong
2026-06-23 16:10 ` David Howells
2026-06-24 1:26 ` ChenXiaoSong
2026-06-24 7:36 ` David Howells
2026-06-24 10:59 ` David Howells
2026-06-24 11:02 ` David Howells
2026-06-23 14:53 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2877069.1782226433@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=hongao@uniontech.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.org \
--cc=syzbot+3c74b1f0c372e98efc32@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox