From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 1/7] FS-Cache: Provide a filesystem-specific sync'able page bit Date: Fri, 21 Apr 2006 11:22:55 +0100 Message-ID: <28997.1145614975@warthog.cambridge.redhat.com> References: <20060420171216.4cdd369a.akpm@osdl.org> <20060420165927.9968.33912.stgit@warthog.cambridge.redhat.com> Cc: aviro@redhat.com, sct@redhat.com, nfsv4@linux-nfs.org, steved@redhat.com, linux-kernel@vger.kernel.org, David Howells , torvalds@osdl.org, linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org Return-path: In-Reply-To: <20060420171216.4cdd369a.akpm@osdl.org> To: Andrew Morton List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfsv4-bounces@linux-nfs.org Errors-To: nfsv4-bounces@linux-nfs.org List-Id: linux-fsdevel.vger.kernel.org Andrew Morton wrote: > It would be better to rename PG_checked to PG_fs_misc kernel-wide. So would deleting PG_checked and changing the PageChecked() macros to: #define PageChecked(page) PageFsMisc((page)) #define SetPageChecked(page) SetPageFsMisc((page)) #define ClearPageChecked(page) ClearPageFsMisc((page)) be acceptable? Or would you rather I replaced those too? David