From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.alarsen.net (mail.alarsen.net [144.76.18.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DADE3135A71 for ; Tue, 27 Feb 2024 12:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=144.76.18.233 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709037852; cv=none; b=DGqI3NOMBvv2y6QAQ73t94Deghxy9y2cO2Z7q4TptDF9hSeEe14DkXhnO84AEoiN4MBEgFnO21odcLAV95MD+crYNElEy569f8S4SPIKwcpr0AZMMBW+V/yN9LFOyfv/fVCyDTaxRWxRmxkoYrVklRRpCLCI6eAleWbaahZFlu0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709037852; c=relaxed/simple; bh=IUeNbRQm7Wa/Lyw1UXo1/EbkKD6WhImA5NiJJkGf3A4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YoSSCailnYzUCRdTHGqu8S3uBAGoCy2aKHGYJInmOvGLFaD7+nRfj9fWlOA6EskMJ4+gowueaLx2q3qBZbxDs3xyAJtGG3HtwmuX4CW/8SfiUPEMRvw7hIEqUJapSzptNVt+nvahAYev/yePK+rA28of6G6YUCuxEQuC+b0hD2c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alarsen.net; spf=pass smtp.mailfrom=alarsen.net; dkim=pass (1024-bit key) header.d=alarsen.net header.i=@alarsen.net header.b=AzKtCQ5T; arc=none smtp.client-ip=144.76.18.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=alarsen.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alarsen.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=alarsen.net header.i=@alarsen.net header.b="AzKtCQ5T" Received: from oscar.alarsen.net (unknown [IPv6:fd8b:531:bccf:96:254a:dddb:8815:7250]) by joe.alarsen.net (Postfix) with ESMTPS id 92F27180161; Tue, 27 Feb 2024 13:43:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alarsen.net; s=joe; t=1709037835; bh=Zt4PvLIs+NQ1rLVcNFg5BIvl31lSuYOspLZAowbr3vM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AzKtCQ5Tgw5LwswwfB2j2h1f64xWLR9vQT5VdSbuqkm8hNCOKNllsk1y1CFUkg2Be w00sfqq4F5/NyRNu6uJS4Y53yccnjyRblpZRVzPGjTOx9y0TOAl6qQH64vFRDT39Hu PrRyECxYL6LaxKxZgvjISCr0Vn9ckzIS9NtI54EU= Received: from oscar.localnet (localhost [IPv6:::1]) by oscar.alarsen.net (Postfix) with ESMTPS id 7D4FAB58; Tue, 27 Feb 2024 13:43:55 +0100 (CET) From: Anders Larsen To: linux-fsdevel@vger.kernel.org, Bill O'Donnell Cc: brauner@kernel.org, sandeen@redhat.com, Bill O'Donnell Subject: Re: [PATCH] qnx4: convert qnx4 to use the new mount api Date: Tue, 27 Feb 2024 13:43:55 +0100 Message-ID: <2925451.e9J7NaK4W3@oscar> In-Reply-To: <20240226224628.710547-1-bodonnel@redhat.com> References: <20240226224628.710547-1-bodonnel@redhat.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On 2024-02-26 23:46 Bill O'Donnell wrote: > Convert the qnx4 filesystem to use the new mount API. > > Tested mount, umount, and remount using a qnx4 boot image. > > Signed-off-by: Bill O'Donnell Acked-by: Anders Larsen > --- > fs/qnx4/inode.c | 49 +++++++++++++++++++++++++++++++------------------ > 1 file changed, 31 insertions(+), 18 deletions(-) > > diff --git a/fs/qnx4/inode.c b/fs/qnx4/inode.c > index 6eb9bb369b57..c36fbe45a0e9 100644 > --- a/fs/qnx4/inode.c > +++ b/fs/qnx4/inode.c > @@ -21,6 +21,7 @@ > #include > #include > #include > +#include > #include "qnx4.h" > > #define QNX4_VERSION 4 > @@ -30,28 +31,33 @@ static const struct super_operations qnx4_sops; > > static struct inode *qnx4_alloc_inode(struct super_block *sb); > static void qnx4_free_inode(struct inode *inode); > -static int qnx4_remount(struct super_block *sb, int *flags, char *data); > static int qnx4_statfs(struct dentry *, struct kstatfs *); > +static int qnx4_get_tree(struct fs_context *fc); > > static const struct super_operations qnx4_sops = > { > .alloc_inode = qnx4_alloc_inode, > .free_inode = qnx4_free_inode, > .statfs = qnx4_statfs, > - .remount_fs = qnx4_remount, > }; > > -static int qnx4_remount(struct super_block *sb, int *flags, char *data) > +static int qnx4_reconfigure(struct fs_context *fc) > { > - struct qnx4_sb_info *qs; > + struct super_block *sb = fc->root->d_sb; > + struct qnx4_sb_info *qs = sb->s_fs_info; > > sync_filesystem(sb); > qs = qnx4_sb(sb); > qs->Version = QNX4_VERSION; > - *flags |= SB_RDONLY; > + fc->sb_flags |= SB_RDONLY; > return 0; > } > > +static const struct fs_context_operations qnx4_context_opts = { > + .get_tree = qnx4_get_tree, > + .reconfigure = qnx4_reconfigure, > +}; > + > static int qnx4_get_block( struct inode *inode, sector_t iblock, struct > buffer_head *bh, int create ) { > unsigned long phys; > @@ -183,12 +189,13 @@ static const char *qnx4_checkroot(struct super_block > *sb, return "bitmap file not found."; > } > > -static int qnx4_fill_super(struct super_block *s, void *data, int silent) > +static int qnx4_fill_super(struct super_block *s, struct fs_context *fc) > { > struct buffer_head *bh; > struct inode *root; > const char *errmsg; > struct qnx4_sb_info *qs; > + int silent = fc->sb_flags & SB_SILENT; > > qs = kzalloc(sizeof(struct qnx4_sb_info), GFP_KERNEL); > if (!qs) > @@ -216,7 +223,7 @@ static int qnx4_fill_super(struct super_block *s, void > *data, int silent) errmsg = qnx4_checkroot(s, (struct qnx4_super_block *) > bh->b_data); brelse(bh); > if (errmsg != NULL) { > - if (!silent) > + if (!silent) > printk(KERN_ERR "qnx4: %s\n", errmsg); > return -EINVAL; > } > @@ -235,6 +242,18 @@ static int qnx4_fill_super(struct super_block *s, void > *data, int silent) return 0; > } > > +static int qnx4_get_tree(struct fs_context *fc) > +{ > + return get_tree_bdev(fc, qnx4_fill_super); > +} > + > +static int qnx4_init_fs_context(struct fs_context *fc) > +{ > + fc->ops = &qnx4_context_opts; > + > + return 0; > +} > + > static void qnx4_kill_sb(struct super_block *sb) > { > struct qnx4_sb_info *qs = qnx4_sb(sb); > @@ -376,18 +395,12 @@ static void destroy_inodecache(void) > kmem_cache_destroy(qnx4_inode_cachep); > } > > -static struct dentry *qnx4_mount(struct file_system_type *fs_type, > - int flags, const char *dev_name, void *data) > -{ > - return mount_bdev(fs_type, flags, dev_name, data, qnx4_fill_super); > -} > - > static struct file_system_type qnx4_fs_type = { > - .owner = THIS_MODULE, > - .name = "qnx4", > - .mount = qnx4_mount, > - .kill_sb = qnx4_kill_sb, > - .fs_flags = FS_REQUIRES_DEV, > + .owner = THIS_MODULE, > + .name = "qnx4", > + .kill_sb = qnx4_kill_sb, > + .fs_flags = FS_REQUIRES_DEV, > + .init_fs_context = qnx4_init_fs_context, > }; > MODULE_ALIAS_FS("qnx4");