From: "Josh Triplett" <josh@joshtriplett.org>
To: brauner@kernel.org
Cc: jlayton@kernel.org, josef@toxicpanda.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
luca.boccassi@gmail.com, oleg@redhat.com, paul@paul-moore.com
Subject: Re: [PATCH] pidfd: add ioctl to retrieve pid info
Date: Mon, 07 Oct 2024 07:54:35 -0700 [thread overview]
Message-ID: <2ab879f1-2938-4ece-a6b2-be34e4ad4c5d@app.fastmail.com> (raw)
In-Reply-To: <20241004-signal-erfolg-c76d6fdeee1c@brauner>
Christian Brauner wrote:
> struct pidfd_info {
> /* Let userspace request expensive stuff explictly. */
> __u64 request_mask;
> /* And let the kernel indicate whether it knows about it. */
> __u64 result_mask;
I don't think it's necessary to have these two fields separate. The kernel should write to the same mask field userspace used.
In theory there could be an operation to probe for *everything* the kernel understands, but in practice with a binary structure there's little point finding out about flags you don't know the corresponding structure bits for.
next prev parent reply other threads:[~2024-10-07 14:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241002142516.110567-1-luca.boccassi@gmail.com>
2024-10-04 9:29 ` [PATCH] pidfd: add ioctl to retrieve pid info Christian Brauner
2024-10-04 14:05 ` Paul Moore
2024-10-04 18:50 ` Luca Boccassi
2024-10-04 19:29 ` Oleg Nesterov
2024-10-04 19:40 ` Luca Boccassi
2024-10-05 11:29 ` Oleg Nesterov
2024-10-06 14:59 ` Luca Boccassi
2024-10-06 19:18 ` David Laight
2024-10-07 14:54 ` Josh Triplett [this message]
[not found] ` <CAHC9VhRV3KcNGRw6_c-97G6w=HKNuEQoUGrfKhsQdWywzDDnBQ@mail.gmail.com>
[not found] ` <CAMw=ZnSkm1U-gBEy9MBbjo2gP2+WHV2LyCsKmwYu2cUJqSUeXg@mail.gmail.com>
[not found] ` <CAHC9VhRY81Wp-=jC6-G=6y4e=TSe-dznO=j87i-i+t6GVq4m3w@mail.gmail.com>
2024-10-22 23:45 ` luca.boccassi
2024-10-22 23:56 ` Luca Boccassi
2024-10-24 23:14 ` Paul Moore
2024-10-24 23:31 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ab879f1-2938-4ece-a6b2-be34e4ad4c5d@app.fastmail.com \
--to=josh@joshtriplett.org \
--cc=brauner@kernel.org \
--cc=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.boccassi@gmail.com \
--cc=oleg@redhat.com \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).