From: Pavel Begunkov <asml.silence@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, io-uring@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC for-next v2 3/4] block/bio: add pcpu caching for non-polling bio_put
Date: Thu, 20 Oct 2022 13:26:16 +0100 [thread overview]
Message-ID: <2b29a76c-682e-208f-8a0f-d693b6823482@gmail.com> (raw)
In-Reply-To: <Y1EHb36rQgqwbsXD@infradead.org>
On 10/20/22 09:31, Christoph Hellwig wrote:
>> + unsigned long flags;
>>
>> cache = per_cpu_ptr(bio->bi_pool->cache, get_cpu());
>> bio_uninit(bio);
>> @@ -737,12 +776,15 @@ static inline void bio_put_percpu_cache(struct bio *bio)
>> cache->free_list = bio;
>> cache->nr++;
>> } else {
>> - put_cpu();
>> - bio_free(bio);
>> - return;
>> + local_irq_save(flags);
>> + bio->bi_next = cache->free_list_irq;
>> + cache->free_list_irq = bio;
>> + cache->nr_irq++;
>> + local_irq_restore(flags);
>> }
>
> Ok, I guess with that my previous comments don't make quite
> as much sense any more. I think youcan keep flags local in
Yeah, a little bit of oracle coding
> the branch here, though.
Not like it makes any difference but can move it
--
Pavel Begunkov
next prev parent reply other threads:[~2022-10-20 12:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 19:50 [RFC for-next v2 0/4] enable pcpu bio caching for IRQ I/O Pavel Begunkov
2022-10-18 19:50 ` [RFC for-next v2 1/4] bio: safeguard REQ_ALLOC_CACHE bio put Pavel Begunkov
2022-10-20 8:26 ` Christoph Hellwig
2022-10-18 19:50 ` [RFC for-next v2 2/4] bio: split pcpu cache part of bio_put into a helper Pavel Begunkov
2022-10-20 8:30 ` Christoph Hellwig
2022-10-18 19:50 ` [RFC for-next v2 3/4] block/bio: add pcpu caching for non-polling bio_put Pavel Begunkov
2022-10-20 8:31 ` Christoph Hellwig
2022-10-20 12:26 ` Pavel Begunkov [this message]
2022-10-18 19:50 ` [RFC for-next v2 4/4] io_uring/rw: enable bio caches for IRQ rw Pavel Begunkov
2022-10-20 8:32 ` [RFC for-next v2 0/4] enable pcpu bio caching for IRQ I/O Christoph Hellwig
2022-10-20 12:40 ` Pavel Begunkov
2022-10-20 12:53 ` Jens Axboe
2022-10-20 12:50 ` (subset) " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b29a76c-682e-208f-8a0f-d693b6823482@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).