From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81774C43381 for ; Fri, 22 Feb 2019 01:48:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FC942075C for ; Fri, 22 Feb 2019 01:48:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726335AbfBVBsd (ORCPT ); Thu, 21 Feb 2019 20:48:33 -0500 Received: from shelob.surriel.com ([96.67.55.147]:44974 "EHLO shelob.surriel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726313AbfBVBsd (ORCPT ); Thu, 21 Feb 2019 20:48:33 -0500 Received: from imladris.surriel.com ([96.67.55.152]) by shelob.surriel.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1gwzwy-0005YH-6m; Thu, 21 Feb 2019 20:48:28 -0500 Message-ID: <2d4e6dd7a546640c9ecb6a60b730d6c3a3da980b.camel@surriel.com> Subject: Re: [LSF/MM TOPIC] dying memory cgroups and slab reclaim issues From: Rik van Riel To: Roman Gushchin , Dave Chinner Cc: "lsf-pc@lists.linux-foundation.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "dchinner@redhat.com" , "guroan@gmail.com" , Kernel Team , "hannes@cmpxchg.org" Date: Thu, 21 Feb 2019 20:48:27 -0500 In-Reply-To: <20190221224616.GB24252@tower.DHCP.thefacebook.com> References: <20190219071329.GA7827@castle.DHCP.thefacebook.com> <20190220024723.GA20682@dastard> <20190220055031.GA23020@dastard> <20190220072707.GB23020@dastard> <20190221224616.GB24252@tower.DHCP.thefacebook.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-lgNl1vNCER8PgHS4HqER" X-Mailer: Evolution 3.28.5 (3.28.5-1.fc28) Mime-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org --=-lgNl1vNCER8PgHS4HqER Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2019-02-21 at 17:46 -0500, Roman Gushchin wrote: > On Wed, Feb 20, 2019 at 06:27:07PM +1100, Dave Chinner wrote: > > On Wed, Feb 20, 2019 at 04:50:31PM +1100, Dave Chinner wrote: > > > I'm just going to fix the original regression in the shrinker > > > algorithm by restoring the gradual accumulation behaviour, and > > > this > > > whole series of problems can be put to bed. > >=20 > > Something like this lightly smoke tested patch below. It may be > > slightly more agressive than the original code for really small > > freeable values (i.e. < 100) but otherwise should be roughly > > equivalent to historic accumulation behaviour. > >=20 > > Cheers, > >=20 > > Dave. > > --=20 > > Dave Chinner > > david@fromorbit.com > >=20 > > mm: fix shrinker scan accumulation regression > >=20 > > From: Dave Chinner >=20 > JFYI: I'm testing this patch in our environment for fixing > the memcg memory leak. >=20 > It will take a couple of days to get reliable results. Just to clarify, is this test with fls instead of ilog2, so the last item in a slab cache can get reclaimed as well? --=20 All Rights Reversed. --=-lgNl1vNCER8PgHS4HqER Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAlxvVOsACgkQznnekoTE 3oOfBQf/ZOlT9BiynvY+97b0klsAkgxIn6y8HLGrY/NPn+M456BBbr6XT6p4I1YH wfpwJ0yg7rGR53tzhUD4b0gkQ5QVMuoJf8rkNMxtYLKFB3k2kK9Q9ZNBvqTZFXYt /rjEc48Df+qMPWlnBZOmYttyh/YgzR7QKKrGjR2fENzf1akiTO0vZMKcahGLSsYK gk/NMYee+vrL6+hpgM2BwpjIulnSa+y2qmzL9ndJS71Fl3A+6HG5bBy2eBikOGBP a0guVyi6+tqaxnNN0BKs50NLYllwzNdeiNo/jlNNrO+5lNphG+OqI3cXTIzpy1fG 1qL+DgNy5rLZq3B/+QY+tUnPNqr9ig== =9IbL -----END PGP SIGNATURE----- --=-lgNl1vNCER8PgHS4HqER--