* [PATCH RESEND] f2fs: optimize f2fs_write_cache_pages
@ 2015-07-17 4:56 Tiezhu Yang
0 siblings, 0 replies; only message in thread
From: Tiezhu Yang @ 2015-07-17 4:56 UTC (permalink / raw)
To: jaegeuk, cm224.lee, chao2.yu
Cc: linux-f2fs-devel, linux-fsdevel, linux-kernel
The if statement "goto continue_unlock" is exactly the same when
each if condition is true that is depended on the value of both
"step" and "is_cold_data(page)" are 0 or 1. That means when the
value of "step" equals to "is_cold_data(page)", the if condition
is true and the if statement "goto continue_unlock" appears only
once, so it can be optimized to reduce the duplicated code.
Signed-off-by: Tiezhu Yang <kernelpatch@126.com>
---
fs/f2fs/data.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index b621c08..0219bd0 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1214,9 +1214,7 @@ continue_unlock:
goto continue_unlock;
}
- if (step == 0 && !is_cold_data(page))
- goto continue_unlock;
- if (step == 1 && is_cold_data(page))
+ if (step == is_cold_data(page))
goto continue_unlock;
if (PageWriteback(page)) {
--
1.8.3.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-07-17 4:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-17 4:56 [PATCH RESEND] f2fs: optimize f2fs_write_cache_pages Tiezhu Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).