From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FF37C433F5 for ; Thu, 21 Oct 2021 12:35:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58B56611CE for ; Thu, 21 Oct 2021 12:35:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231593AbhJUMh7 (ORCPT ); Thu, 21 Oct 2021 08:37:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:21531 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231644AbhJUMh6 (ORCPT ); Thu, 21 Oct 2021 08:37:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634819742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pcCL6CdZH83Z0UE+ms2Bf+J5zETTW6d5Cs7+RZXJ0w4=; b=FS5M2hXVko72B0ZLo/FIWg7myw/aeyjxEpjOlE1upyYZuzJ2WfNFtba1revCPkJvt5C2FA m6bu5WlImBXZ1c19wuQumA0XsLhnGdMSBLPljaGqo8KT+/iR+zmGjXaP8a7kFDpNjKky7U QgI97t6asyENgbbOnFqwLkr5jjSQ43M= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-35-FsiyJVs8O76-nTZ6bZHQOg-1; Thu, 21 Oct 2021 08:35:35 -0400 X-MC-Unique: FsiyJVs8O76-nTZ6bZHQOg-1 Received: by mail-wm1-f69.google.com with SMTP id l187-20020a1c25c4000000b0030da46b76daso1630887wml.9 for ; Thu, 21 Oct 2021 05:35:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:organization:subject :in-reply-to:content-transfer-encoding; bh=pcCL6CdZH83Z0UE+ms2Bf+J5zETTW6d5Cs7+RZXJ0w4=; b=O7Re6Z9/T8gasiYKeNgqd4a/HkKOHqkUvmAhwHNv9krTQc1LFUtwOVsRLVlONSb1bU TamPVspryrA+NNBPBTvqrmIdxdlV8l7oM2n/1tbNG5919LoTEskKUjzQB5P2u0VSqWoS QQBtb3NI/MdnIkkk7vVlP1WWywLnPCRjBxPu8YWIkplglnEXD/66jyM+00/UjLEfP9Nu 4fiYiIMjAC95kFga6wkdULXI/2cS9oaCMReYoa6qQFeXGkIru3F2KKt44tI6RE5ZJe7P eu1iGwwuqNmgM/4+TxMqtEbaLTOq9ft+yvgds+yqPsW3k2ghKD+2/Lw5r9eF70FAiuur HdQg== X-Gm-Message-State: AOAM530UIv+PyybaRsQbYFlr//fSZK0PeXRwGYdvxpRhrEHq/e2oMja9 tkldAa29bLd7ZWmtb77YG2Ri4PqayBWVWq5aSS43ZEvXBcLcLtX5v/Xn3yxCCjB9TZLigVMDVE9 rD0Utq+EXXGxNAvcAy0Ud4U4QrA== X-Received: by 2002:a5d:598a:: with SMTP id n10mr6855142wri.93.1634819734162; Thu, 21 Oct 2021 05:35:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygTB13YIzbisqOQrzKIUBIvuJx4J8sCISPd+GfQ3nZfE1HhayO8oEr5WMTr4X9Cpc4e9kMVQ== X-Received: by 2002:a5d:598a:: with SMTP id n10mr6855104wri.93.1634819733890; Thu, 21 Oct 2021 05:35:33 -0700 (PDT) Received: from [192.168.3.132] (p4ff23aba.dip0.t-ipconnect.de. [79.242.58.186]) by smtp.gmail.com with ESMTPSA id x7sm4732213wrq.69.2021.10.21.05.35.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Oct 2021 05:35:33 -0700 (PDT) Message-ID: <2fc2c5da-c0e9-b954-ba48-e258b88e3271@redhat.com> Date: Thu, 21 Oct 2021 14:35:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Content-Language: en-US To: Kent Overstreet Cc: Christoph Hellwig , Matthew Wilcox , Johannes Weiner , "Kirill A. Shutemov" , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , "Darrick J. Wong" , David Howells , Hugh Dickins References: <20211018231627.kqrnalsi74bgpoxu@box.shutemov.name> <996b3ac4-1536-2152-f947-aad6074b046a@redhat.com> <436a9f9c-d5af-7d12-b7d2-568e45ffe0a0@redhat.com> From: David Hildenbrand Organization: Red Hat Subject: Re: Folios for 5.15 request - Was: re: Folio discussion recap - In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 21.10.21 14:03, Kent Overstreet wrote: > On Thu, Oct 21, 2021 at 09:21:17AM +0200, David Hildenbrand wrote: >> On 21.10.21 08:51, Christoph Hellwig wrote: >>> FYI, with my block and direct I/O developer hat on I really, really >>> want to have the folio for both file and anon pages. Because to make >>> the get_user_pages path a _lot_ more efficient it should store folios. >>> And to make that work I need them to work for file and anon pages >>> because for get_user_pages and related code they are treated exactly >>> the same. > > ++ > >> Thanks, I can understand that. And IMHO that would be even possible with >> split types; the function prototype will simply have to look a little >> more fancy instead of replacing "struct page" by "struct folio". :) > > Possible yes, but might it be a little premature to split them? Personally, I think it's the right thing to do to introduce something limited like "struct filemap" (again, bad name, i.e., folio restricted to the filemap API) first and avoid introducing a generic folio thingy. So I'd even consider going with folios all the way premature. But I assume what to consider premature and what not depends on the point of view already. And maybe that's the biggest point where we all disagree. Anyhow, what I don't quite understand is the following: as the first important goal, we want to improve the filemap API; that's a noble goal and I highly appreciate Willy's work. To improve the API, there is absolutely no need introduce generic folio. Yet we argue about whether generic folio vs. filemap specific folio seems to be the right thing to do as a first step. My opinion after all the discussions: use a dedicate type with a clear name to solve the immediate filemap API issue. Leave the remainder alone for now. Less code to touch, less subsystems to involve (well, still a lot), less people to upset, less discussions to have, faster review, faster upstream, faster progress. A small but reasonable step. But maybe I'm just living in a dream world :) -- Thanks, David / dhildenb