From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from smtp.codeaurora.org ([198.145.29.96]:40636 "EHLO
        smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725845AbeHQNMV (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Fri, 17 Aug 2018 09:12:21 -0400
To: Al Viro <viro@ZenIV.linux.org.uk>, linux-fsdevel@vger.kernel.org,
        lkml <linux-kernel@vger.kernel.org>
From: Mukesh Ojha <mojha@codeaurora.org>
Subject: Query on shrink list
Message-ID: <301a5546-d326-d78e-3be6-41b5a6a08c0e@codeaurora.org>
Date: Fri, 17 Aug 2018 15:39:22 +0530
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Hi Al Viro,

Is there is reason we have kept data->found++, if the dentry already 
there in shrink list ?

static enum d_walk_ret select_collect(
...
         if (dentry->d_flags & DCACHE_SHRINK_LIST) {
                 data->found++;
         } else {
   ..

If the dentry is already there on shrink list, does it not mean that 
data->found is already non-zero ?
Can't we just go out from here directly?


Regards,
Mukesh