Re: [PATCH 7/17] jffs2: convert jffs2_gc_fetch_page to read_cache_page

Nate Diller
2007-04-12T18:29:23Z

On 4/12/07, Phillip Lougher <phillip@lougher.demon.co.uk> wrote:
> Nate Diller wrote:
>
> > + page = read_cache_page(OFNI_EDONI_2SFFJ(f)->i_mapping,
> > + start >> PAGE_CACHE_SHIFT,
> > + (void *)jffs2_do_readpage_unlock,
> > + OFNI_EDONI_2SFFJ(f));
> >
> > - if (IS_ERR(pg_ptr)) {
> > + if (IS_ERR(page)) {
> > printk(KERN_WARNING "read_cache_page() returned error: %ld\n", PTR_ERR(pg_ptr));
>
> should be
>
> printk(KERN_WARNING "read_cache_page() returned error: %ld\n", PTR_ERR(page));
>
> > - return PTR_ERR(pg_ptr);
> > + return PTR_ERR(page);
>

wow, you're right. I was sure I compile-tested this ... oh, "depends
on MTD". oops.

thanks for reviewing. does it look OK to you otherwise?

NATE