linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Linux Filesystem Development <linux-fsdevel@vger.kernel.org>,
	Steve Dickson <SteveD@redhat.com>
Subject: Re: NFS4 mount problem
Date: Mon, 18 Apr 2005 11:34:10 +0100	[thread overview]
Message-ID: <31006.1113820450@redhat.com> (raw)
In-Reply-To: <1113766415.13680.79.camel@lade.trondhjem.org>


Trond Myklebust <trond.myklebust@fys.uio.no> wrote:

> > We've come across an interesting problem with NFS4 mount on a PPC64 box. If
> > the mount program is compiled as PPC32, then the mount() syscall is returned
> > EFAULT.
>
> So, why is this not a case of "Doctor it hurts..."?

Because:

 (1) The kernel is returning EFAULT to the 32-bit userspace; this implies that
     userspace is handing over a bad address. It isn't, the kernel is
     malfunctioning as it stands.

 (2) The kernel API does not prohibit 32-bit userspace calling mount() under a
     64-bit kernel. All other filesystems cope with it (AFAIK), so NFS4 must
     too.

Either the kernel should return ENOSYS for any 32-bit mount on a 64-bit kernel
or it must support it fully. I think the latter is the right thing to do;
despite what you'd prefer, there are other callers of the mount syscall out
there.

> There should therefore be exactly ONE instance of usage, and that is in
> the "mount" program itself.

Exactly. That should then be the ppc32 mount; which should work equally well
with a ppc32 or a ppc64 kernel.

David

  parent reply	other threads:[~2005-04-18 10:34 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-15 11:57 NFS4 mount problem David Howells
2005-04-15 12:21 ` Stephen Rothwell
2005-04-15 19:51   ` Bryan Henderson
2005-04-15 20:22     ` David S. Miller
2005-04-15 22:07       ` Bryan Henderson
2005-04-17 13:55       ` Christoph Hellwig
2005-04-18 17:07         ` Bryan Henderson
2005-04-18 17:16           ` Al Viro
2005-04-18 17:33           ` David Howells
2005-04-18 17:43             ` Al Viro
2005-04-18 17:52             ` Bryan Henderson
2005-04-18 10:36       ` David Howells
2005-04-18 18:37         ` David S. Miller
2005-04-17 19:33 ` Trond Myklebust
2005-04-18 17:17   ` Bryan Henderson
2005-04-18 17:59     ` Trond Myklebust
2005-04-20 10:57       ` Andries Brouwer
2005-04-18 10:34 ` David Howells [this message]
2005-04-18 14:49   ` Trond Myklebust
2005-04-18 22:07     ` Bryan Henderson
2005-04-18 23:34       ` Trond Myklebust
2005-04-18 15:23   ` David Howells
2005-04-18 15:45     ` Trond Myklebust
2005-04-18 21:50   ` Bryan Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31006.1113820450@redhat.com \
    --to=dhowells@redhat.com \
    --cc=SteveD@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).