linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Jeff Layton <jlayton@redhat.com>
Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	mszeredi@redhat.com
Subject: Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags
Date: Fri, 09 Jun 2017 17:04:24 +0100	[thread overview]
Message-ID: <31121.1497024264@warthog.procyon.org.uk> (raw)
In-Reply-To: <1497022434.5056.4.camel@redhat.com>

Jeff Layton <jlayton@redhat.com> wrote:

> I guess you mean stuff like affs_fill_super which does:
> 
>     sb->s_flags |= MS_NODEV | MS_NOSUID;
> 
> It seems like it's doing that too late to be useful.

Actually, after the change, it seems nothing actually tests SB_NOSUID,
SB_NODEV or SB_NOEXEC, so those bits should probably be removed.

I also wonder if the internal MS_ flags (eg. MS_SUBMOUNT) should be removed
from the UAPI header.

David

  parent reply	other threads:[~2017-06-09 16:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-09 15:01 [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags David Howells
2017-06-09 15:33 ` Jeff Layton
2017-06-09 16:04 ` David Howells [this message]
2017-06-10 17:15 ` kbuild test robot
2017-06-14 14:56   ` David Howells
2017-06-10 17:59 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31121.1497024264@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=jlayton@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mszeredi@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).