From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:47604 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751534AbdFIQEd (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Fri, 9 Jun 2017 12:04:33 -0400
From: David Howells <dhowells@redhat.com>
In-Reply-To: <1497022434.5056.4.camel@redhat.com>
References: <1497022434.5056.4.camel@redhat.com> <149702046967.13949.14361137102849681738.stgit@warthog.procyon.org.uk>
To: Jeff Layton <jlayton@redhat.com>
Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        mszeredi@redhat.com
Subject: Re: [PATCH] VFS: Differentiate mount flags (MS_*) from internal superblock flags
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31120.1497024264.1@warthog.procyon.org.uk>
Date: Fri, 09 Jun 2017 17:04:24 +0100
Message-ID: <31121.1497024264@warthog.procyon.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

Jeff Layton <jlayton@redhat.com> wrote:

> I guess you mean stuff like affs_fill_super which does:
> 
>     sb->s_flags |= MS_NODEV | MS_NOSUID;
> 
> It seems like it's doing that too late to be useful.

Actually, after the change, it seems nothing actually tests SB_NOSUID,
SB_NODEV or SB_NOEXEC, so those bits should probably be removed.

I also wonder if the internal MS_ flags (eg. MS_SUBMOUNT) should be removed
from the UAPI header.

David