From: Jeff Layton <jlayton@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Eric Van Hensbergen <ericvh@gmail.com>,
Latchesar Ionkov <lucho@ionkov.net>,
Dominique Martinet <asmadeus@codewreck.org>,
Joel Becker <jlbec@evilplan.org>, Christoph Hellwig <hch@lst.de>,
Tejun Heo <tj@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>,
v9fs-developer@lists.sourceforge.net,
Chuck Lever <chuck.lever@oracle.com>,
Phillip Potter <phil@philpotter.co.uk>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: consolidate duplicate dt_type helpers
Date: Thu, 30 Mar 2023 07:15:36 -0400 [thread overview]
Message-ID: <31bd4a176344cd0746f1ec519eb8caca2ef2ba68.camel@kernel.org> (raw)
In-Reply-To: <ZCVpAyA__NrAOVOg@kroah.com>
On Thu, 2023-03-30 at 12:48 +0200, Greg Kroah-Hartman wrote:
> On Thu, Mar 30, 2023 at 06:41:43AM -0400, Jeff Layton wrote:
> > There are three copies of the same dt_type helper sprinkled around the
> > tree. Convert them to use the common fs_umode_to_dtype function instead,
> > which has the added advantage of properly returning DT_UNKNOWN when
> > given a mode that contains an unrecognized type.
> >
> > Cc: Chuck Lever <chuck.lever@oracle.com>
> > Cc: Phillip Potter <phil@philpotter.co.uk>
> > Suggested-by: Christian Brauner <brauner@kernel.org>
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> > fs/configfs/dir.c | 9 ++-------
> > fs/kernfs/dir.c | 8 +-------
> > fs/libfs.c | 9 ++-------
> > 3 files changed, 5 insertions(+), 21 deletions(-)
> >
> > v2: consolidate S_DT helper as well
> > v3: switch existing dt_type helpers to use fs_umode_to_dtype
> > drop v9fs hunks since they're no longer needed
>
> You forgot the "v3" in the subject line :(
>
Yeah, I noticed, sorry. It's the attention to detail that makes me such
a successful kernel developer! ;)
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2023-03-30 11:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 10:41 [PATCH] fs: consolidate duplicate dt_type helpers Jeff Layton
2023-03-30 10:48 ` Greg Kroah-Hartman
2023-03-30 11:15 ` Jeff Layton [this message]
2023-03-30 11:50 ` Christian Brauner
2023-03-30 12:41 ` [PATCH v3] " Christian Brauner
2023-03-31 8:16 ` [PATCH] " Christian Brauner
2023-03-31 9:42 ` Greg Kroah-Hartman
2023-04-03 7:28 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31bd4a176344cd0746f1ec519eb8caca2ef2ba68.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=asmadeus@codewreck.org \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=ericvh@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jlbec@evilplan.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=phil@philpotter.co.uk \
--cc=tj@kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).