From: David Howells <dhowells@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org
Subject: Re: [bug report] smack: Implement filesystem context security hooks
Date: Mon, 28 Jan 2019 14:28:45 +0000 [thread overview]
Message-ID: <32006.1548685725@warthog.procyon.org.uk> (raw)
In-Reply-To: <20190128140426.GA7268@kadam>
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> 724 rc = smack_add_opt(opt, param->string, &fc->security);
> 725 if (!rc) {
> 726 param->string = NULL;
> 727 rc = 1;
> ^^^^^^
> It probably should return zero though...
Yes it should.
David
prev parent reply other threads:[~2019-01-28 14:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 14:04 [bug report] smack: Implement filesystem context security hooks Dan Carpenter
2019-01-28 14:28 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32006.1548685725@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).