From: David Howells <dhowells@redhat.com>
To: Nick Piggin <npiggin@gmail.com>
Cc: dhowells@redhat.com, npiggin@kernel.dk, viro@zeniv.linux.org.uk,
raven@themaw.net, autofs@linux.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 01/18] Add a dentry op to handle automounting rather than abusing follow_link()
Date: Fri, 14 Jan 2011 09:24:47 +0000 [thread overview]
Message-ID: <32127.1294997087@redhat.com> (raw)
In-Reply-To: <AANLkTimcjg-JaVr1w=sCNQHTWFxquPvpL=YJZNGTN3cY@mail.gmail.com>
Nick Piggin <npiggin@gmail.com> wrote:
> You still have to notice that it is .d_automount in rcu-walk mode, and bail
> out if it is. I can't see where you do that.
follow_managed(), and thus follow_automount() and ->d_automount(), are never
reached in rcu_walk mode, from what I can tell of the code.
There are two places follow_managed() is called:
(1) do_lookup() - where follow_managed() is only called in the else-part of
an if-statement contingent on a check of LOOKUP_RCU.
(2) do_last() - where follow_managed() is subsequent to a mutex having been
taken, so rcu-walk mode must have been exited prior to this as the
process may have needed to sleep.
At least, I'm assuming you may not sleep whilst in rcu-walk mode.
David
next prev parent reply other threads:[~2011-01-14 9:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 17:48 [PATCH 00/18] Introduce automount support in the VFS David Howells
2011-01-11 17:48 ` [PATCH 01/18] Add a dentry op to handle automounting rather than abusing follow_link() David Howells
2011-01-13 3:53 ` Nick Piggin
2011-01-13 5:10 ` Nick Piggin
2011-01-13 15:12 ` David Howells
2011-01-14 1:19 ` Nick Piggin
2011-01-14 16:24 ` Al Viro
2011-01-14 22:14 ` Nick Piggin
2011-01-13 12:20 ` David Howells
2011-01-14 1:04 ` Nick Piggin
2011-01-14 9:24 ` David Howells [this message]
2011-01-11 17:48 ` [PATCH 02/18] AFS: Use d_automount() " David Howells
2011-01-11 17:48 ` [PATCH 03/18] NFS: " David Howells
2011-01-11 17:48 ` [PATCH 04/18] CIFS: " David Howells
2011-01-11 17:48 ` [PATCH 05/18] Remove the automount through follow_link() kludge code from pathwalk David Howells
2011-01-11 17:48 ` [PATCH 06/18] Add an AT_NO_AUTOMOUNT flag to suppress terminal automount David Howells
2011-01-11 17:48 ` [PATCH 07/18] Add more dentry flags for special function directories David Howells
2011-01-11 17:48 ` [PATCH 08/18] Make follow_down() handle d_manage() David Howells
2011-01-11 17:48 ` [PATCH 09/18] autofs4: Add d_automount() dentry operation David Howells
2011-01-11 17:49 ` [PATCH 10/18] autofs4: Add d_manage() " David Howells
2011-01-11 17:49 ` [PATCH 11/18] autofs4: Remove unused code David Howells
2011-01-11 17:49 ` [PATCH 12/18] autofs4: Clean up inode operations David Howells
2011-01-11 17:49 ` [PATCH 13/18] autofs4: Clean up dentry operations David Howells
2011-01-11 17:49 ` [PATCH 14/18] autofs4: Clean up autofs4_free_ino() David Howells
2011-01-11 17:49 ` [PATCH 15/18] autofs4: Fix wait validation David Howells
2011-01-11 17:49 ` [PATCH 16/18] autofs4: Add v4 pseudo direct mount support David Howells
2011-01-11 17:49 ` [PATCH 17/18] autofs4: Bump version David Howells
2011-01-11 17:49 ` [PATCH 18/18] Remove a further kludge from __do_follow_link() David Howells
2011-01-12 13:52 ` [PATCH 07/18] Add more dentry flags for special function directories [UPDATE] David Howells
2011-01-12 19:16 ` [PATCH 00/18] Introduce automount support in the VFS David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32127.1294997087@redhat.com \
--to=dhowells@redhat.com \
--cc=autofs@linux.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=npiggin@kernel.dk \
--cc=raven@themaw.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).