From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 14/45] writeback: quit on wrap for .range_cyclic (afs) Date: Wed, 07 Oct 2009 11:17:06 +0100 Message-ID: <32495.1254910626@redhat.com> References: <20091007074902.913463607@intel.com> <20091007073818.318088777@intel.com> Cc: dhowells@redhat.com, Andrew Morton , Theodore Tso , Christoph Hellwig , Dave Chinner , Chris Mason , Peter Zijlstra , "Li Shaohua" , "Myklebust Trond" , "jens.axboe@oracle.com" , Jan Kara , Nick Piggin , linux-fsdevel@vger.kernel.org, LKML To: Wu Fengguang Return-path: In-Reply-To: <20091007074902.913463607@intel.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Wu Fengguang wrote: > Convert wbc.range_cyclic to new behavior: when past EOF, abort writeback > of the inode, which instructs writeback_single_inode() to delay it for > a while if necessary. > > It removes one inefficient .range_cyclic IO pattern when writeback_index > wraps: > submit [10000-10100], (wrap), submit [0-100] > In which the submitted pages may be consisted of two distant ranges. > > It also prevents submitting pointless IO for busy overwriters. > > CC: David Howells > Signed-off-by: Wu Fengguang Acked-by: David Howells