Re: [PATCH v4] statx: optimize copy of struct statx to userspace

[David Howells <dhowells@redhat.com>]

Eric Biggers <ebiggers3@gmail.com> wrote:

> stat() instead initializes its struct on the stack and copies it to
> userspace with a single call to copy_to_user().  This turns out to be
> much faster, and changing statx to do this makes it almost as fast as
> stat:

I wonder if we actually need to copy __spare2 at the end.  We could define any
future values added in there to be unset/undefined if the respective bits are
not set.

I would prefer it to be cleaner, however, and clear the unused space.

Another thought is does it make sense to rearrange struct kstat to mirror
the first part of struct statx so that this can be memcpy'd?

David