From: Randy Dunlap <rdunlap@infradead.org>
To: "Christian König" <christian.koenig@amd.com>,
"Stephen Rothwell" <sfr@canb.auug.org.au>
Cc: akpm@linux-foundation.org, broonie@kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz,
mm-commits@vger.kernel.org, Rob Clark <robdclark@gmail.com>,
Sean Paul <sean@poorly.run>,
linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics <intel-gfx@lists.freedesktop.org>,
DRI <dri-devel@lists.freedesktop.org>
Subject: Re: mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o)
Date: Wed, 6 Oct 2021 11:05:41 -0700 [thread overview]
Message-ID: <34c2f6ab-3982-a031-1af6-5ed482b5c344@infradead.org> (raw)
In-Reply-To: <f877a1c9-1898-23f3-bba3-3442dc1f3979@amd.com>
On 10/6/21 12:24 AM, Christian König wrote:
>
>
> Am 06.10.21 um 09:20 schrieb Stephen Rothwell:
>> Hi Randy,
>>
>> On Tue, 5 Oct 2021 22:48:03 -0700 Randy Dunlap <rdunlap@infradead.org> wrote:
>>> on i386:
>>>
>>> ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg'
>>>
>>>
>>> Full randconfig fle is attached.
>> This would be because CONFIG_DRM_MSM is set but CONFIG_COMMON_CLOCK is
>> not and has been exposed by commit
>>
>> b3ed524f84f5 ("drm/msm: allow compile_test on !ARM")
>>
>> from the drm-misc tree.
>
> Good point, how about this change:
>
> diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig
> index 5879f67bc88c..d9879b011fb0 100644
> --- a/drivers/gpu/drm/msm/Kconfig
> +++ b/drivers/gpu/drm/msm/Kconfig
> @@ -5,7 +5,7 @@ config DRM_MSM
> depends on DRM
> depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST
> depends on IOMMU_SUPPORT
> - depends on (OF && COMMON_CLK) || COMPILE_TEST
> + depends on (OF || COMPILE_TEST) && COMMON_CLK
> depends on QCOM_OCMEM || QCOM_OCMEM=n
> depends on QCOM_LLCC || QCOM_LLCC=n
> depends on QCOM_COMMAND_DB || QCOM_COMMAND_DB=n
WorksForMe. Thanks.
(other than the whitespace damage)
--
~Randy
next prev parent reply other threads:[~2021-10-06 18:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 2:53 mmotm 2021-10-05-19-53 uploaded akpm
2021-10-06 5:48 ` mmotm 2021-10-05-19-53 uploaded (drivers/gpu/drm/msm/hdmi/hdmi_phy.o) Randy Dunlap
2021-10-06 7:20 ` Stephen Rothwell
2021-10-06 7:24 ` Christian König
2021-10-06 18:05 ` Randy Dunlap [this message]
2021-10-07 9:28 ` Geert Uytterhoeven
2021-10-13 10:54 ` Arnd Bergmann
2021-10-13 11:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34c2f6ab-3982-a031-1af6-5ed482b5c344@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).