From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: dhowells@redhat.com, Jens Axboe <axboe@kernel.dk>,
Keith Busch <kbusch@kernel.org>,
Hannes Reinecke <hare@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Paulo Alcantara <pc@manguebit.org>,
netfs@lists.linux.dev, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] block: Fix start and length check added to iov_iter_extract_bvecs()
Date: Fri, 04 Sep 2026 10:42:17 +0100 [thread overview]
Message-ID: <350212.1788514937@warthog.procyon.org.uk> (raw)
In-Reply-To: <20260902112743.GA11999@lst.de>
Christoph Hellwig <hch@lst.de> wrote:
> Should this grow a comment explaining why for non-iov/kvec/ubuf
> we check the alignment of every sector instead of just the
> start alignment?
There should possibly be a comment explaining the need for an address
alignment at all. Is it mandatory for all devices? Or are we being a bit
over restrictive? I don't think NICs capable of RDMA are so restricted, for
example.
Note that iov_iter_alignment() for ITER_XARRAY and ITER_FOLIOQ basically just
check iov_offset and count anyway as they refer to whole pages/folios only,
with just the start and end reduced.
David
prev parent reply other threads:[~2026-09-04 9:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 18:18 [PATCH] block: Fix start and length check added to iov_iter_extract_bvecs() David Howells
2026-08-26 18:34 ` Keith Busch
2026-08-26 19:24 ` David Howells
2026-08-26 19:47 ` Keith Busch
2026-08-26 20:23 ` David Howells
2026-08-26 19:49 ` David Howells
2026-08-26 20:02 ` Keith Busch
2026-08-26 20:46 ` [PATCH v2] " David Howells
2026-08-26 20:52 ` Keith Busch
2026-08-26 20:54 ` David Howells
2026-09-02 11:27 ` Christoph Hellwig
2026-09-04 9:42 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=350212.1788514937@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=axboe@kernel.dk \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox